Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1709053002: [Telemetry] Fix interaction record label warnings (Closed)

Created:
4 years, 10 months ago by perezju
Modified:
4 years, 10 months ago
CC:
catapult-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Fix interaction record label warnings Fix the smoothness timeline based metric so it doesn't produce these warnings; and make the warning message itself a bit less spammy. BUG=catapult:#2025 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/edb9067dbc83befe6b4fc0dc7560af618e8f2525

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M telemetry/telemetry/web_perf/metrics/smoothness.py View 2 chunks +5 lines, -3 lines 0 comments Download
M telemetry/telemetry/web_perf/metrics/smoothness_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/web_perf/timeline_based_measurement.py View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 8 (3 generated)
perezju
Lately I had been getting increasingly annoyed by these warnings when developing a new benchmark. ...
4 years, 10 months ago (2016-02-18 15:23:23 UTC) #2
nednguyen
lgtm Thanks Juan, hehe
4 years, 10 months ago (2016-02-18 15:55:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709053002/1
4 years, 10 months ago (2016-02-18 16:11:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/edb9067dbc83befe6b4fc0dc7560af618e8f2525
4 years, 10 months ago (2016-02-18 16:21:47 UTC) #7
eakuefner
4 years, 9 months ago (2016-03-09 21:00:13 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1777073002/ by eakuefner@chromium.org.

The reason for reverting is: Changed smoothness metric names on dashboard
because tir_label was not being automatically inserted before..

Powered by Google App Engine
This is Rietveld 408576698