Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: telemetry/telemetry/web_perf/metrics/smoothness.py

Issue 1709053002: [Telemetry] Fix interaction record label warnings (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/web_perf/metrics/smoothness.py
diff --git a/telemetry/telemetry/web_perf/metrics/smoothness.py b/telemetry/telemetry/web_perf/metrics/smoothness.py
index fee30ff8734cd5a2b2dd2d804cb4df43c0828422..b501dd31795d7f02c3c97769d43ab54d4a1602a6 100644
--- a/telemetry/telemetry/web_perf/metrics/smoothness.py
+++ b/telemetry/telemetry/web_perf/metrics/smoothness.py
@@ -55,10 +55,11 @@ class SmoothnessMetric(timeline_based_metric.TimelineBasedMetric):
renderer_process, model.browser_process, model.surface_flinger_process,
[r.GetBounds() for r in interaction_records])
has_surface_flinger_stats = model.surface_flinger_process is not None
- self._PopulateResultsFromStats(results, stats, has_surface_flinger_stats)
+ self._PopulateResultsFromStats(results, stats, has_surface_flinger_stats,
+ interaction_records[0].label)
- def _PopulateResultsFromStats(self, results, stats,
- has_surface_flinger_stats):
+ def _PopulateResultsFromStats(
+ self, results, stats, has_surface_flinger_stats, tir_label):
page = results.current_page
values = [
self._ComputeQueueingDuration(page, stats),
@@ -77,6 +78,7 @@ class SmoothnessMetric(timeline_based_metric.TimelineBasedMetric):
values += self._ComputeSurfaceFlingerMetric(page, stats)
for v in values:
+ v.tir_label = tir_label
results.AddValue(v)
def _HasEnoughFrames(self, list_of_frame_timestamp_lists):

Powered by Google App Engine
This is Rietveld 408576698