telemetry/telemetry/web_perf/timeline_based_measurement.py - Issue 1709053002: [Telemetry] Fix interaction record label warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/web_perf/timeline_based_measurement.py

Issue 1709053002: [Telemetry] Fix interaction record label warnings (Closed) Base URL: git@github.com:catapult-project/catapult@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/web_perf/timeline_based_measurement.py

diff --git a/telemetry/telemetry/web_perf/timeline_based_measurement.py b/telemetry/telemetry/web_perf/timeline_based_measurement.py

index 63b492e7941c5cf2f7c4e60ce494c1aea0242318..f8421f9a7a70120bdd5624c6de28cb1a1dc16c81 100644

--- a/telemetry/telemetry/web_perf/timeline_based_measurement.py

+++ b/telemetry/telemetry/web_perf/timeline_based_measurement.py

@@ -88,7 +88,7 @@ class _TBMResultWrapper(ResultsWrapperInterface):

else:

logging.warning(

'TimelineBasedMetric should create the interaction record label '

- 'for the value themselves. Value: %s' % repr(value))

+ 'for %r values.' % value.name)

perezju 2016/02/18 15:23:23 produce a less spammy and more useful warning mess

value.tir_label = self._tir_label

self._results.AddValue(value)

« no previous file with comments | « telemetry/telemetry/web_perf/metrics/smoothness_unittest.py ('k') | no next file » | no next file with comments »