components/sessions_strings.grdp - Issue 1708593002: Componentize IDS_SESSION_CRASHED_* to allow sharing with iOS.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/sessions_strings.grdp

Issue 1708593002: Componentize IDS_SESSION_CRASHED_* to allow sharing with iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <grit-part>

	3

	4 <message name="IDS_SESSION_CRASHED_VIEW_RESTORE_BUTTON" desc="Title of the res tore button in the session crashed view.">

	5 Restore

	6 </message>

	7 <if expr="_google_chrome">
	Peter Kasting 2016/02/17 22:14:20 Is this the pattern we've been using elsewhere? I Is this the pattern we've been using elsewhere? I'm concerned that it's not parallel to the "one file per differently-named port" solution, primarily since I don't understand enough about why that solution was implemented to know if this poses problems for other Chromium-based named products or something. Did the l10n people sign off on this methodology? sdefresne 2016/02/18 09:34:22 Actually, components strings currently uses both. Show quoted text On 2016/02/17 at 22:14:20, Peter Kasting wrote: > Is this the pattern we've been using elsewhere? I'm concerned that it's not parallel to the "one file per differently-named port" solution, primarily since I don't understand enough about why that solution was implemented to know if this poses problems for other Chromium-based named products or something. Did the l10n people sign off on this methodology? Actually, components strings currently uses both. See components/components_chromium_strings.grd & components/components_google_chrome_strings.grd. Moved the branded string to those files instead (since as you pointed out this is better for other products based on Chromium).
	8 <message name="IDS_SESSION_CRASHED_VIEW_MESSAGE" desc="Message shown when th e last session didn't exit cleanly.">

	9 Chrome didn't shut down correctly.

	10 </message>

	11 </if>

	12 <if expr="not _google_chrome">

	13 <message name="IDS_SESSION_CRASHED_VIEW_MESSAGE" desc="Message shown when th e last session didn't exit cleanly.">

	14 Chromium didn't shut down correctly.

	15 </message>

	16 </if>

	17

	18 </grit-part>

OLD	NEW

« no previous file with comments | « components/components_strings.grd ('k') | no next file » | no next file with comments »