Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1708583002: Revert of More simplification and unification of frame handling (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, Jarin
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of More simplification and unification of frame handling (patchset #5 id:80001 of https://codereview.chromium.org/1702593002/ ) Reason for revert: [Sheriff] Breaks nosnap debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/5329 Original issue's description: > More simplification and unification of frame handling > > Frame slots indexes numbers are used more consistently for > computation in both TurboFan and Crankshaft. Specifically, > Crankshaft now uses frame slot indexes in LChunk, removing > the need for some special-case maths when building the > deoptimization translation table. > > LOG=N > R=mstarzinger@chromium.org > > Committed: https://crrev.com/81423b84dbb2eaf7e1a57b0f6029fc8e643b4755 > Cr-Commit-Position: refs/heads/master@{#34078} TBR=mstarzinger@chromium.org,jarin@chromium.org,danno@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/c8117f2fd918c17bcae3c1c93e05979f243529db Cr-Commit-Position: refs/heads/master@{#34082}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -160 lines) Patch
M src/compiler/frame.h View 2 chunks +26 lines, -7 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.h View 2 chunks +5 lines, -9 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 5 chunks +9 lines, -3 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.h View 2 chunks +5 lines, -9 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 4 chunks +8 lines, -2 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.h View 2 chunks +5 lines, -9 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 5 chunks +9 lines, -3 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M src/crankshaft/lithium.h View 3 chunks +4 lines, -9 lines 0 comments Download
M src/crankshaft/lithium.cc View 3 chunks +18 lines, -4 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.h View 2 chunks +5 lines, -9 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 5 chunks +9 lines, -3 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.h View 2 chunks +5 lines, -9 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 5 chunks +10 lines, -4 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.h View 2 chunks +5 lines, -9 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 4 chunks +8 lines, -2 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/frames.h View 2 chunks +0 lines, -46 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of More simplification and unification of frame handling
4 years, 10 months ago (2016-02-17 14:48:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708583002/1
4 years, 10 months ago (2016-02-17 14:49:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 14:49:20 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 14:49:57 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8117f2fd918c17bcae3c1c93e05979f243529db
Cr-Commit-Position: refs/heads/master@{#34082}

Powered by Google App Engine
This is Rietveld 408576698