Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: src/crankshaft/ia32/lithium-codegen-ia32.h

Issue 1708583002: Revert of More simplification and unification of frame handling (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/arm64/lithium-codegen-arm64.cc ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/ia32/lithium-codegen-ia32.h
diff --git a/src/crankshaft/ia32/lithium-codegen-ia32.h b/src/crankshaft/ia32/lithium-codegen-ia32.h
index 589ef2e05e557aa0b34f292a6b43af94d409fed3..06a3e10bf2668b0304a347f230087c153b2274f0 100644
--- a/src/crankshaft/ia32/lithium-codegen-ia32.h
+++ b/src/crankshaft/ia32/lithium-codegen-ia32.h
@@ -47,8 +47,10 @@
}
bool NeedsEagerFrame() const {
- return HasAllocatedStackSlots() || info()->is_non_deferred_calling() ||
- !info()->IsStub() || info()->requires_frame();
+ return GetStackSlotCount() > 0 ||
+ info()->is_non_deferred_calling() ||
+ !info()->IsStub() ||
+ info()->requires_frame();
}
bool NeedsDeferredFrame() const {
return !NeedsEagerFrame() && info()->is_deferred_calling();
@@ -130,13 +132,7 @@
Register temporary,
Register temporary2);
- bool HasAllocatedStackSlots() const {
- return chunk()->HasAllocatedStackSlots();
- }
- int GetStackSlotCount() const { return chunk()->GetSpillSlotCount(); }
- int GetTotalFrameSlotCount() const {
- return chunk()->GetTotalFrameSlotCount();
- }
+ int GetStackSlotCount() const { return chunk()->spill_slot_count(); }
void AddDeferredCode(LDeferredCode* code) { deferred_.Add(code, zone()); }
« no previous file with comments | « src/crankshaft/arm64/lithium-codegen-arm64.cc ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698