More simplification and unification of frame handling

More simplification and unification of frame handling

Frame slots indexes numbers are used more consistently for
computation in both TurboFan and Crankshaft. Specifically,
Crankshaft now uses frame slot indexes in LChunk, removing
the need for some special-case maths when building the
deoptimization translation table.

LOG=N
R=mstarzinger@chromium.org

Committed: https://crrev.com/81423b84dbb2eaf7e1a57b0f6029fc8e643b4755
Cr-Commit-Position: refs/heads/master@{#34078}

Committed: https://crrev.com/55071954bcd65be6782388624b986e9751899377
Cr-Commit-Position: refs/heads/master@{#34114}

[danno, 2016-02-17 07:38:57]

Description was changed from

==========
More simplication and unification of frame handling
==========

to

==========
More simplification and unification of frame handling

Frame slots indexes numbers are used more consistently for
computation in both TurboFan and Crankshaft. Specifically,
Crankshaft now uses frame slot indexes in LChunk, removing
the need for some special-case maths when building the
deoptimization translation table.

LOG=N
R=mstarzinger@chromium.org
==========

[danno, 2016-02-17 07:39:16]

PTAL

[danno, 2016-02-17 11:39:14]

danno@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[danno, 2016-02-17 11:39:22]

PATL

[Jarin, 2016-02-17 11:48:30]

jarin@chromium.org changed reviewers:
+ jarin@chromium.org

[Jarin, 2016-02-17 11:48:31]

lgtm.

https://codereview.chromium.org/1702593002/diff/40001/src/frames.h
File src/frames.h (right):

https://codereview.chromium.org/1702593002/diff/40001/src/frames.h#newcode136
src/frames.h:136: //   1   | saved frame ptr | Fixed                      |
There can be an optional constant pool here, no?

(It is still a bit confusing that the constants below are relative to FP -
rather than the return address.)

[danno, 2016-02-17 12:21:02]

The CQ bit was checked by danno@chromium.org

[danno, 2016-02-17 12:21:02]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/1702593002/#ps60001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-02-17 12:21:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702593002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702593002/60001

[commit-bot: I haz the power, 2016-02-17 12:42:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 12:42:16]

Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/15574)

[danno, 2016-02-17 12:52:21]

https://codereview.chromium.org/1702593002/diff/40001/src/frames.h
File src/frames.h (right):

https://codereview.chromium.org/1702593002/diff/40001/src/frames.h#newcode136
src/frames.h:136: //   1   | saved frame ptr | Fixed                      |
On 2016/02/17 11:48:31, Jarin wrote:
> There can be an optional constant pool here, no?
> 
> (It is still a bit confusing that the constants below are relative to FP -
> rather than the return address.)

Fixed the picture. I plan to try to make the fp/ra offset clearer in a follow-up
CL.

[danno, 2016-02-17 12:52:27]

The CQ bit was checked by danno@chromium.org

[danno, 2016-02-17 12:52:27]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/1702593002/#ps80001
(title: "Fix bogus assert")

[commit-bot: I haz the power, 2016-02-17 12:52:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702593002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702593002/80001

[commit-bot: I haz the power, 2016-02-17 13:19:09]

Description was changed from

==========
More simplification and unification of frame handling

Frame slots indexes numbers are used more consistently for
computation in both TurboFan and Crankshaft. Specifically,
Crankshaft now uses frame slot indexes in LChunk, removing
the need for some special-case maths when building the
deoptimization translation table.

LOG=N
R=mstarzinger@chromium.org
==========

to

==========
More simplification and unification of frame handling

Frame slots indexes numbers are used more consistently for
computation in both TurboFan and Crankshaft. Specifically,
Crankshaft now uses frame slot indexes in LChunk, removing
the need for some special-case maths when building the
deoptimization translation table.

LOG=N
R=mstarzinger@chromium.org
==========

[commit-bot: I haz the power, 2016-02-17 13:19:10]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-17 13:19:35]

Description was changed from

==========
More simplification and unification of frame handling

Frame slots indexes numbers are used more consistently for
computation in both TurboFan and Crankshaft. Specifically,
Crankshaft now uses frame slot indexes in LChunk, removing
the need for some special-case maths when building the
deoptimization translation table.

LOG=N
R=mstarzinger@chromium.org
==========

to

==========
More simplification and unification of frame handling

Frame slots indexes numbers are used more consistently for
computation in both TurboFan and Crankshaft. Specifically,
Crankshaft now uses frame slot indexes in LChunk, removing
the need for some special-case maths when building the
deoptimization translation table.

LOG=N
R=mstarzinger@chromium.org

Committed: https://crrev.com/81423b84dbb2eaf7e1a57b0f6029fc8e643b4755
Cr-Commit-Position: refs/heads/master@{#34078}
==========

[commit-bot: I haz the power, 2016-02-17 13:19:36]

Patchset 5 (id:??) landed as
https://crrev.com/81423b84dbb2eaf7e1a57b0f6029fc8e643b4755
Cr-Commit-Position: refs/heads/master@{#34078}

[Michael Starzinger, 2016-02-17 14:08:37]

LGTM.

[Michael Achenbach, 2016-02-17 14:48:53]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1708583002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks nosnap debug:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%2....

[danno, 2016-02-17 15:44:02]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1707703002/ by danno@chromium.org.

The reason for reverting is: Breaks no snap.

[danno, 2016-02-18 08:47:32]

Description was changed from

==========
More simplification and unification of frame handling

Frame slots indexes numbers are used more consistently for
computation in both TurboFan and Crankshaft. Specifically,
Crankshaft now uses frame slot indexes in LChunk, removing
the need for some special-case maths when building the
deoptimization translation table.

LOG=N
R=mstarzinger@chromium.org

Committed: https://crrev.com/81423b84dbb2eaf7e1a57b0f6029fc8e643b4755
Cr-Commit-Position: refs/heads/master@{#34078}
==========

to

==========
More simplification and unification of frame handling

Frame slots indexes numbers are used more consistently for
computation in both TurboFan and Crankshaft. Specifically,
Crankshaft now uses frame slot indexes in LChunk, removing
the need for some special-case maths when building the
deoptimization translation table.

LOG=N
R=mstarzinger@chromium.org

Committed: https://crrev.com/81423b84dbb2eaf7e1a57b0f6029fc8e643b4755
Cr-Commit-Position: refs/heads/master@{#34078}
==========

[danno, 2016-02-18 08:47:36]

The CQ bit was checked by danno@chromium.org

[danno, 2016-02-18 08:47:37]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1702593002/#ps100001
(title: "Fix build breakage")

[commit-bot: I haz the power, 2016-02-18 08:47:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702593002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702593002/100001

[commit-bot: I haz the power, 2016-02-18 09:07:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 09:07:04]

Try jobs failed on following builders:
  v8_win64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/3094)
  v8_win64_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[danno, 2016-02-18 11:12:38]

The CQ bit was checked by danno@chromium.org

[danno, 2016-02-18 11:12:38]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1702593002/#ps120001
(title: "Fix other platforms")

[commit-bot: I haz the power, 2016-02-18 11:12:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702593002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702593002/120001

[danno, 2016-02-18 11:31:01]

The CQ bit was unchecked by danno@chromium.org

[danno, 2016-02-18 12:50:04]

The CQ bit was checked by danno@chromium.org

[danno, 2016-02-18 12:50:05]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1702593002/#ps140001
(title: "Fix arm64")

[commit-bot: I haz the power, 2016-02-18 12:50:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1702593002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1702593002/140001

[commit-bot: I haz the power, 2016-02-18 12:51:52]

Description was changed from

==========
More simplification and unification of frame handling

Frame slots indexes numbers are used more consistently for
computation in both TurboFan and Crankshaft. Specifically,
Crankshaft now uses frame slot indexes in LChunk, removing
the need for some special-case maths when building the
deoptimization translation table.

LOG=N
R=mstarzinger@chromium.org

Committed: https://crrev.com/81423b84dbb2eaf7e1a57b0f6029fc8e643b4755
Cr-Commit-Position: refs/heads/master@{#34078}
==========

to

==========
More simplification and unification of frame handling

Frame slots indexes numbers are used more consistently for
computation in both TurboFan and Crankshaft. Specifically,
Crankshaft now uses frame slot indexes in LChunk, removing
the need for some special-case maths when building the
deoptimization translation table.

LOG=N
R=mstarzinger@chromium.org

Committed: https://crrev.com/81423b84dbb2eaf7e1a57b0f6029fc8e643b4755
Cr-Commit-Position: refs/heads/master@{#34078}
==========

[commit-bot: I haz the power, 2016-02-18 12:51:54]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-02-18 12:52:09]

Description was changed from

==========
More simplification and unification of frame handling

Frame slots indexes numbers are used more consistently for
computation in both TurboFan and Crankshaft. Specifically,
Crankshaft now uses frame slot indexes in LChunk, removing
the need for some special-case maths when building the
deoptimization translation table.

LOG=N
R=mstarzinger@chromium.org

Committed: https://crrev.com/81423b84dbb2eaf7e1a57b0f6029fc8e643b4755
Cr-Commit-Position: refs/heads/master@{#34078}
==========

to

==========
More simplification and unification of frame handling

Frame slots indexes numbers are used more consistently for
computation in both TurboFan and Crankshaft. Specifically,
Crankshaft now uses frame slot indexes in LChunk, removing
the need for some special-case maths when building the
deoptimization translation table.

LOG=N
R=mstarzinger@chromium.org

Committed: https://crrev.com/81423b84dbb2eaf7e1a57b0f6029fc8e643b4755
Cr-Commit-Position: refs/heads/master@{#34078}

Committed: https://crrev.com/55071954bcd65be6782388624b986e9751899377
Cr-Commit-Position: refs/heads/master@{#34114}
==========

[commit-bot: I haz the power, 2016-02-18 12:52:10]

Patchset 8 (id:??) landed as
https://crrev.com/55071954bcd65be6782388624b986e9751899377
Cr-Commit-Position: refs/heads/master@{#34114}