Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Unified Diff: chrome/browser/lifetime/keep_alive_options.h

Issue 1708343002: Add ScopedKeepAlive to c/b/lifetime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address PS7 comments, replace strings by a struct ptr, chromeappdelegate ctor takes a boolean Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/lifetime/keep_alive_options.h
diff --git a/chrome/browser/lifetime/keep_alive_options.h b/chrome/browser/lifetime/keep_alive_options.h
new file mode 100644
index 0000000000000000000000000000000000000000..7be9de3663e8679571d2be1dc3770d4b09844c1f
--- /dev/null
+++ b/chrome/browser/lifetime/keep_alive_options.h
@@ -0,0 +1,20 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_LIFETIME_KEEP_ALIVE_OPTIONS_H_
+#define CHROME_BROWSER_LIFETIME_KEEP_ALIVE_OPTIONS_H_
+
+struct KeepAliveOptions {
+ // Should be descriptive of what the KeepAlive's lifetime is tied to, to help
+ // with debugging.
+ const char label[32];
Bernhard Bauer 2016/02/22 18:19:38 I think const char* should work here; no need to a
dgn 2016/02/22 19:07:19 Thanks, done. If it's longer the compiler would de
+
+ // TODO(dgn)
+ // When registering a token, indictations of which kind of optimizations would
Bernhard Bauer 2016/02/22 18:19:38 Nit: "indications". Also, the passive voice is us
dgn 2016/02/22 19:07:19 Done.
+ // be allowed during the KeepAlive's lifetime should be provided. This allows
+ // to take some liberties with the state of the browser to optimize
+ // the resource consumption.
+};
+
+#endif // CHROME_BROWSER_LIFETIME_KEEP_ALIVE_OPTIONS_H_

Powered by Google App Engine
This is Rietveld 408576698