chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.cc - Issue 1708343002: Add ScopedKeepAlive to c/b/lifetime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.cc

Issue 1708343002: Add ScopedKeepAlive to c/b/lifetime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address PS7 comments, replace strings by a struct ptr, chromeappdelegate ctor takes a boolean Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/background/background_mode_manager.cc ('K') | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | chrome/browser/lifetime/keep_alive_options.h » ('j') | chrome/browser/lifetime/keep_alive_options.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.cc

diff --git a/chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.cc b/chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.cc

index 47d4c36138299fb3c2b66624be5b40315f3cdb99..d7a27b21958554a3848d796789ff30832f2a5153 100644

--- a/chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.cc

+++ b/chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.cc

@@ -6,7 +6,6 @@

#include <utility>

-#include "chrome/browser/apps/scoped_keep_alive.h"

#include "chrome/browser/renderer_context_menu/render_view_context_menu.h"

#include "chrome/browser/ui/apps/chrome_app_delegate.h"

#include "components/renderer_context_menu/context_menu_delegate.h"

@@ -33,7 +32,7 @@ bool ChromeAppViewGuestDelegate::HandleContextMenu(

}

AppDelegate* ChromeAppViewGuestDelegate::CreateAppDelegate() {

- return new ChromeAppDelegate(make_scoped_ptr(new ScopedKeepAlive));

+ return new ChromeAppDelegate(true);

}

} // namespace extensions