chrome/browser/lifetime/keep_alive_options.h - Issue 1708343002: Add ScopedKeepAlive to c/b/lifetime

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/lifetime/keep_alive_options.h

Issue 1708343002: Add ScopedKeepAlive to c/b/lifetime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address PS7 comments, replace strings by a struct ptr, chromeappdelegate ctor takes a boolean Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/background/background_mode_manager.cc ('K') | « chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.cc ('k') | chrome/browser/lifetime/keep_alive_registry.h » ('j') | chrome/browser/lifetime/keep_alive_registry.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_LIFETIME_KEEP_ALIVE_OPTIONS_H_

	6 #define CHROME_BROWSER_LIFETIME_KEEP_ALIVE_OPTIONS_H_

	7

	8 struct KeepAliveOptions {

	9 // Should be descriptive of what the KeepAlive's lifetime is tied to, to help

	10 // with debugging.

	11 const char label[32];
	Bernhard Bauer 2016/02/22 18:19:38 I think const char* should work here; no need to a I think const char* should work here; no need to artificially limit the size of the label (and then have to worry about what would happen if someone were to use a longer label...). dgn 2016/02/22 19:07:19 Thanks, done. If it's longer the compiler would de Show quoted text On 2016/02/22 18:19:38, Bernhard Bauer wrote: > I think const char* should work here; no need to artificially limit the size of > the label (and then have to worry about what would happen if someone were to use > a longer label...). Thanks, done. If it's longer the compiler would detect it and show an error.
	12

	13 // TODO(dgn)

	14 // When registering a token, indictations of which kind of optimizations would
	Bernhard Bauer 2016/02/22 18:19:38 Nit: "indications". Also, the passive voice is us Nit: "indications". Also, the passive voice is used a bit too much in this sentence. Maybe just, "[...] we should add [...]" dgn 2016/02/22 19:07:19 Done. Show quoted text On 2016/02/22 18:19:38, Bernhard Bauer wrote: > Nit: "indications". > > Also, the passive voice is used a bit too much in this sentence. Maybe just, > "[...] we should add [...]" Done.
	15 // be allowed during the KeepAlive's lifetime should be provided. This allows

	16 // to take some liberties with the state of the browser to optimize

	17 // the resource consumption.

	18 };

	19

	20 #endif // CHROME_BROWSER_LIFETIME_KEEP_ALIVE_OPTIONS_H_

OLD	NEW