Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1708253004: mojo: Get mojo:leveldb and mojo:filesystem compiled into content. (Closed)

Created:
4 years, 10 months ago by Elliot Glaysher
Modified:
4 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo: Get mojo:leveldb and mojo:filesystem compiled into content. BUG=585587 Committed: https://crrev.com/2853a31774a299712b767eb75cda5ca95f4be8b5 Cr-Commit-Position: refs/heads/master@{#376779}

Patch Set 1 #

Patch Set 2 : Fix windows compile? #

Patch Set 3 : Windows is inscrutible. #

Patch Set 4 : Another attempt at getting gyp to not flake. #

Patch Set 5 : Merge with ToT #

Patch Set 6 : Why gyp? Why? #

Patch Set 7 : More export_dependent_settings? #

Patch Set 8 : Maybe these deps will fix the world. (I would like gyp to stop existing.) #

Patch Set 9 : This at least clobber builds locally. #

Patch Set 10 : And hook up leveldb service now that gyp works. #

Patch Set 11 : Remove changes from content/browser/renderer_host/ #

Patch Set 12 : Probable fix to the build flake. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -193 lines) Patch
M components/filesystem/BUILD.gn View 4 chunks +4 lines, -3 lines 0 comments Download
M components/filesystem/file_system_app.h View 1 chunk +0 lines, -29 lines 0 comments Download
M components/filesystem/file_system_app.cc View 2 chunks +2 lines, -66 lines 0 comments Download
M components/filesystem/file_system_impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M components/filesystem/file_system_impl.cc View 3 chunks +3 lines, -7 lines 0 comments Download
A components/filesystem/filesystem.gyp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +68 lines, -0 lines 0 comments Download
M components/leveldb/BUILD.gn View 3 chunks +6 lines, -3 lines 0 comments Download
A components/leveldb/leveldb.gyp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +64 lines, -0 lines 0 comments Download
M components/leveldb/leveldb_app.h View 3 chunks +2 lines, -14 lines 0 comments Download
M components/leveldb/leveldb_app.cc View 3 chunks +3 lines, -44 lines 0 comments Download
A components/leveldb/leveldb_service_impl.h View 1 2 3 4 5 6 7 8 9 1 chunk +37 lines, -0 lines 0 comments Download
A + components/leveldb/leveldb_service_impl.cc View 2 chunks +8 lines, -24 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
A mojo/mojo_platform_handle.gyp View 1 2 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Elliot Glaysher
This is now good enough for review. This mainly just compiles leveldb and filesystem into ...
4 years, 10 months ago (2016-02-19 22:54:44 UTC) #2
jam
lgtm without render_process_host_impl changes as we chatted
4 years, 10 months ago (2016-02-20 00:27:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708253004/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708253004/200001
4 years, 10 months ago (2016-02-20 00:41:05 UTC) #6
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 10 months ago (2016-02-20 01:59:39 UTC) #7
commit-bot: I haz the power
Patchset 11 (id:??) landed as https://crrev.com/d42c4081fdb8fa382d5b0af101a45106b4d12d4c Cr-Commit-Position: refs/heads/master@{#376606}
4 years, 10 months ago (2016-02-20 02:00:47 UTC) #9
Ben Goodger (Google)
A revert of this CL (patchset #11 id:200001) has been created in https://codereview.chromium.org/1720603002/ by ben@chromium.org. ...
4 years, 10 months ago (2016-02-20 15:29:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708253004/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708253004/220001
4 years, 10 months ago (2016-02-22 18:38:46 UTC) #15
commit-bot: I haz the power
Committed patchset #12 (id:220001)
4 years, 10 months ago (2016-02-22 19:58:42 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 20:00:04 UTC) #19
Message was sent while issue was closed.
Patchset 12 (id:??) landed as
https://crrev.com/2853a31774a299712b767eb75cda5ca95f4be8b5
Cr-Commit-Position: refs/heads/master@{#376779}

Powered by Google App Engine
This is Rietveld 408576698