Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1708253002: tools/android/loading: Implements loading_trace_analyzer.py requests (Closed)

Created:
4 years, 10 months ago by gabadie
Modified:
4 years, 10 months ago
Reviewers:
Benoit L, mattcary
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@i01
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/android/loading: Implements loading_trace_analyzer.py requests Command line tool design to quickly analyse a loading trace to debug the upcoming cache modification tool. BUG=582080 Committed: https://crrev.com/6ba6f666b3c485e56d4e005d59734c7ab5a64ff2 Cr-Commit-Position: refs/heads/master@{#376737}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addresses benoit's nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -0 lines) Patch
A tools/android/loading/loading_trace_analyzer.py View 1 1 chunk +83 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
gabadie
mattcary@chromium.org & lizeb@google.com: PTAL.
4 years, 10 months ago (2016-02-18 15:59:57 UTC) #2
gabadie
Asking benoit's review on his chromium account instead of google account. mattcary & lizeb: PTAL.
4 years, 10 months ago (2016-02-19 12:17:14 UTC) #4
mattcary
lgtm
4 years, 10 months ago (2016-02-19 15:07:19 UTC) #5
Benoit L
lgtm https://codereview.chromium.org/1708253002/diff/1/tools/android/loading/loading_trace_analyzer.py File tools/android/loading/loading_trace_analyzer.py (right): https://codereview.chromium.org/1708253002/diff/1/tools/android/loading/loading_trace_analyzer.py#newcode16 tools/android/loading/loading_trace_analyzer.py:16: """Build a command line argument's parser. s/Build/Builds/
4 years, 10 months ago (2016-02-22 10:20:46 UTC) #6
gabadie
On 2016/02/22 10:20:46, Benoit L wrote: > lgtm > > https://codereview.chromium.org/1708253002/diff/1/tools/android/loading/loading_trace_analyzer.py > File tools/android/loading/loading_trace_analyzer.py (right): ...
4 years, 10 months ago (2016-02-22 14:47:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708253002/20001
4 years, 10 months ago (2016-02-22 15:40:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-22 16:05:05 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 16:05:49 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6ba6f666b3c485e56d4e005d59734c7ab5a64ff2
Cr-Commit-Position: refs/heads/master@{#376737}

Powered by Google App Engine
This is Rietveld 408576698