Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Issue 1730373002: Reland II of "Implements cachetool to manipulate simple typed cache." (Closed)

Created:
4 years, 10 months ago by gabadie
Modified:
4 years, 10 months ago
Reviewers:
gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@i02
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland II of "Implements cachetool to manipulate simple typed cache." BUG=582080 > Revert of "Implements cachetool to manipulate simple tpyed cache." (patchset #1 id:1 of https://codereview.chromium.org/1724833002/ ) > > Reason for revert: > Sorry, again broke compile on https://build.chromium.org/p/chromium/builders/Win. > > Original issue's description: > > Reland of "Implements cachetool to manipulate simple typed cache." > > > > BUG=582080 > > > > Original issue's description: > > > Revert of Implements cachetool to manipulate simple typed cache. (patchset #4 id:60001 of https://codereview.chromium.org/1710923003/ ) > > > > > > Reason for revert: > > > Broke Win Build, see: https://build.chromium.org/p/chromium/builders/Win/builds/40605. > > > > > > Original issue's description: > > > > Implements cachetool to manipulate simple typed cache. > > > > > > > > BUG=582080 > > > > > > > > Committed: https://crrev.com/ebc4faedfca14bab8f932d03e1332b1b72e8430e > > > > Cr-Commit-Position: refs/heads/master@{#377007} > > > > Committed: https://crrev.com/60d7a305d528afb0e5d1b4a3212ff88371aead80 > > Cr-Commit-Position: refs/heads/master@{#377312} Committed: https://crrev.com/b23de397fb174d086588122a708548003a8092e4 Cr-Commit-Position: refs/heads/master@{#377363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -0 lines) Patch
M net/net.gyp View 1 chunk +12 lines, -0 lines 0 comments Download
A net/tools/cachetool/cachetool.cc View 1 chunk +227 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
gavinp
lgtm. this is really ugly, but it's a tool for a specific use and that's ...
4 years, 10 months ago (2016-02-24 18:44:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730373002/1
4 years, 10 months ago (2016-02-24 18:52:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 20:18:19 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 20:19:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b23de397fb174d086588122a708548003a8092e4
Cr-Commit-Position: refs/heads/master@{#377363}

Powered by Google App Engine
This is Rietveld 408576698