Reland of "Implements cachetool to manipulate simple tpyed cache."

Reland of "Implements cachetool to manipulate simple typed cache."

BUG=582080
Original issue's description:
> Revert of Implements cachetool to manipulate simple typed cache. (patchset #4 id:60001 of https://codereview.chromium.org/1710923003/ )
>
> Reason for revert:
> Broke Win Build, see: https://build.chromium.org/p/chromium/builders/Win/builds/40605.
>
> Original issue's description:
> > Implements cachetool to manipulate simple typed cache.
> >
> > BUG=582080
> >
> > Committed: https://crrev.com/ebc4faedfca14bab8f932d03e1332b1b72e8430e
> > Cr-Commit-Position: refs/heads/master@{#377007}

Committed: https://crrev.com/60d7a305d528afb0e5d1b4a3212ff88371aead80
Cr-Commit-Position: refs/heads/master@{#377312}

[gabadie, 2016-02-23 18:18:55]

Description was changed from

==========
Reland of "Implements cachetool to manipulate simple tpyed cache."

BUG=582080
==========

to

==========
Reland of "Implements cachetool to manipulate simple typed cache."

BUG=582080

Original issue's description:
> Revert of Implements cachetool to manipulate simple typed cache. (patchset #4
id:60001 of https://codereview.chromium.org/1710923003/ )
> 
> Reason for revert:
> Broke Win Build, see:
https://build.chromium.org/p/chromium/builders/Win/builds/40605.
> 
> Original issue's description:
> > Implements cachetool to manipulate simple typed cache.
> >
> > BUG=582080
> >
> > Committed: https://crrev.com/ebc4faedfca14bab8f932d03e1332b1b72e8430e
> > Cr-Commit-Position: refs/heads/master@{#377007}
==========

[gabadie, 2016-02-23 18:20:25]

gabadie@chromium.org changed reviewers:
+ gavinp@chromium.org

[gabadie, 2016-02-23 18:20:26]

gavinp@chromium.org: PTAL.

https://codereview.chromium.org/1724833002/diff/1/net/tools/cachetool/cacheto...
File net/tools/cachetool/cachetool.cc (right):

https://codereview.chromium.org/1724833002/diff/1/net/tools/cachetool/cacheto...
net/tools/cachetool/cachetool.cc:151: #if defined(OS_WIN)
I had broke the build uncovered by try bots. Just made this small change from
the original CL.

[gavinp, 2016-02-23 19:45:55]

https://codereview.chromium.org/1724833002/diff/1/net/tools/cachetool/cacheto...
File net/tools/cachetool/cachetool.cc (right):

https://codereview.chromium.org/1724833002/diff/1/net/tools/cachetool/cacheto...
net/tools/cachetool/cachetool.cc:151: #if defined(OS_WIN)
On 2016/02/23 18:20:25, gabadie wrote:
> I had broke the build uncovered by try bots. Just made this small change from
> the original CL.

I don't think you need the ifdef, and I think the ifdef is undesirable.

https://codereview.chromium.org/1724833002/diff/1/net/tools/cachetool/cacheto...
net/tools/cachetool/cachetool.cc:168: std::string cache_backend_type(args[1]);
use CommandLine::StringType here

https://codereview.chromium.org/1724833002/diff/1/net/tools/cachetool/cacheto...
net/tools/cachetool/cachetool.cc:173: if (cache_backend_type == "simple") {
and here for the literal as well

[gavinp, 2016-02-24 15:23:53]

after our talk, I can lgtm this. I think it'd be best to move this ifdef'd
section out to a custom function basically cut and paste from the gn_main.cc
example you shared. But you can do that or land it as is.

lgtm.

[gabadie, 2016-02-24 15:26:12]

The CQ bit was checked by gabadie@chromium.org

[commit-bot: I haz the power, 2016-02-24 15:27:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1724833002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1724833002/1

[commit-bot: I haz the power, 2016-02-24 17:15:47]

Description was changed from

==========
Reland of "Implements cachetool to manipulate simple typed cache."

BUG=582080

Original issue's description:
> Revert of Implements cachetool to manipulate simple typed cache. (patchset #4
id:60001 of https://codereview.chromium.org/1710923003/ )
> 
> Reason for revert:
> Broke Win Build, see:
https://build.chromium.org/p/chromium/builders/Win/builds/40605.
> 
> Original issue's description:
> > Implements cachetool to manipulate simple typed cache.
> >
> > BUG=582080
> >
> > Committed: https://crrev.com/ebc4faedfca14bab8f932d03e1332b1b72e8430e
> > Cr-Commit-Position: refs/heads/master@{#377007}
==========

to

==========
Reland of "Implements cachetool to manipulate simple typed cache."

BUG=582080

Original issue's description:
> Revert of Implements cachetool to manipulate simple typed cache. (patchset #4
id:60001 of https://codereview.chromium.org/1710923003/ )
> 
> Reason for revert:
> Broke Win Build, see:
https://build.chromium.org/p/chromium/builders/Win/builds/40605.
> 
> Original issue's description:
> > Implements cachetool to manipulate simple typed cache.
> >
> > BUG=582080
> >
> > Committed: https://crrev.com/ebc4faedfca14bab8f932d03e1332b1b72e8430e
> > Cr-Commit-Position: refs/heads/master@{#377007}
==========

[commit-bot: I haz the power, 2016-02-24 17:15:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-24 17:17:16]

Description was changed from

==========
Reland of "Implements cachetool to manipulate simple typed cache."

BUG=582080

Original issue's description:
> Revert of Implements cachetool to manipulate simple typed cache. (patchset #4
id:60001 of https://codereview.chromium.org/1710923003/ )
> 
> Reason for revert:
> Broke Win Build, see:
https://build.chromium.org/p/chromium/builders/Win/builds/40605.
> 
> Original issue's description:
> > Implements cachetool to manipulate simple typed cache.
> >
> > BUG=582080
> >
> > Committed: https://crrev.com/ebc4faedfca14bab8f932d03e1332b1b72e8430e
> > Cr-Commit-Position: refs/heads/master@{#377007}
==========

to

==========
Reland of "Implements cachetool to manipulate simple typed cache."

BUG=582080

Original issue's description:
> Revert of Implements cachetool to manipulate simple typed cache. (patchset #4
id:60001 of https://codereview.chromium.org/1710923003/ )
>
> Reason for revert:
> Broke Win Build, see:
https://build.chromium.org/p/chromium/builders/Win/builds/40605.
>
> Original issue's description:
> > Implements cachetool to manipulate simple typed cache.
> >
> > BUG=582080
> >
> > Committed: https://crrev.com/ebc4faedfca14bab8f932d03e1332b1b72e8430e
> > Cr-Commit-Position: refs/heads/master@{#377007}

Committed: https://crrev.com/60d7a305d528afb0e5d1b4a3212ff88371aead80
Cr-Commit-Position: refs/heads/master@{#377312}
==========

[commit-bot: I haz the power, 2016-02-24 17:17:17]

Patchset 1 (id:??) landed as
https://crrev.com/60d7a305d528afb0e5d1b4a3212ff88371aead80
Cr-Commit-Position: refs/heads/master@{#377312}

[engedy, 2016-02-24 17:51:47]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1730313002/ by engedy@chromium.org.

The reason for reverting is: Sorry, again broke compile on
https://build.chromium.org/p/chromium/builders/Win.

.