tools/android/loading Fix import issues in webserver unittests

tools/android/loading Fix import issues in webserver unittests

Committed: https://crrev.com/b7823f1dab8b7416f1818dfc80c1d322059a5137
Cr-Commit-Position: refs/heads/master@{#376158}

[droger, 2016-02-18 10:58:15]

droger@chromium.org changed reviewers:
+ lizeb@chromium.org

[Benoit L, 2016-02-18 11:01:47]

On 2016/02/18 10:58:15, droger wrote:

lgtm

[droger, 2016-02-18 11:08:30]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2016-02-18 11:09:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 11:09:33]

This CL has an open dependency (Issue 1707173003 Patch 80001). Please resolve
the dependency and try again.

[droger, 2016-02-18 12:58:40]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2016-02-18 12:59:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708143002/1

[commit-bot: I haz the power, 2016-02-18 13:30:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-18 13:30:56]

Description was changed from

==========
tools/android/loading Fix import issues in webserver unittests
==========

to

==========
tools/android/loading Fix import issues in webserver unittests

Committed: https://crrev.com/b7823f1dab8b7416f1818dfc80c1d322059a5137
Cr-Commit-Position: refs/heads/master@{#376158}
==========

[commit-bot: I haz the power, 2016-02-18 13:30:58]

Patchset 1 (id:??) landed as
https://crrev.com/b7823f1dab8b7416f1818dfc80c1d322059a5137
Cr-Commit-Position: refs/heads/master@{#376158}

[chromium-reviews, 2016-02-19 07:57:07]

Does this still allow it to work from tools/android/loading/runtests?

On Thu, Feb 18, 2016 at 11:58 AM, <droger@chromium.org> wrote:

> Reviewers: Benoit L
> CL: https://codereview.chromium.org/1708143002/
>
> Description:
> tools/android/loading Fix import issues in webserver unittests
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@moreOrphans
>
> Affected files (+5, -1 lines):
>   M tools/android/loading/trace_test/webserver_unittest.py
>
>
> Index: tools/android/loading/trace_test/webserver_unittest.py
> diff --git a/tools/android/loading/trace_test/webserver_unittest.py
b/tools/android/loading/trace_test/webserver_unittest.py
> index
2716492e7059b99e407dbf7cd1976efaad16796d..35fcb4d4df91edb55a2da20ed0fcf9ecba484c48
100644
> --- a/tools/android/loading/trace_test/webserver_unittest.py
> +++ b/tools/android/loading/trace_test/webserver_unittest.py
> @@ -8,7 +8,7 @@ import sys
>  import unittest
>
>  _SRC_DIR = os.path.abspath(os.path.join(
> -    os.path.dirname(__file__), '..', '..', '..'))
> +    os.path.dirname(__file__), '..', '..', '..', '..'))
>  sys.path.append(os.path.join(_SRC_DIR, 'tools', 'android', 'loading'))
>
>  import options
> @@ -48,3 +48,7 @@ class TracingTrackTestCase(unittest.TestCase):
>
>        sock.close()
>        self.assertTrue(server.Stop())
> +
> +
> +if __name__ == '__main__':
> +  unittest.main()
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[droger, 2016-02-19 09:02:56]

On 2016/02/19 07:57:07, chromium-reviews wrote:
> Does this still allow it to work from tools/android/loading/runtests?
> 

I think it does:

$ python tools/android/loading/run_tests webserver
testWebserver (trace_test.webserver_unittest.TracingTrackTestCase) ... %%%
HTTP/1.0 200 OK

ok

----------------------------------------------------------------------
Ran 1 test in 0.079s

OK

[chromium-reviews, 2016-02-19 09:13:41]

ok, cool. I had to try a couple times to get the dependencies to work out
correctly. Thx for the CL.

On Fri, Feb 19, 2016 at 10:02 AM, <droger@chromium.org> wrote:

>
> On 2016/02/19 07:57:07, chromium-reviews wrote:
> > Does this still allow it to work from tools/android/loading/runtests?
> >
>
> I think it does:
>
> $ python tools/android/loading/run_tests webserver
> testWebserver (trace_test.webserver_unittest.TracingTrackTestCase) ... %%%
> HTTP/1.0 200 OK
>
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 0.079s
>
> OK
>
> https://codereview.chromium.org/1708143002/
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.