tools/android/loading Ignore timings for requests coming from cache

tools/android/loading Ignore timings for requests coming from cache

The requests coming from Blink cache have stale timings: these
are the timings corresponding to the request that put the content
in the cache, rather than of the request that got them from the cache.

Ignoring these timings allows to fallback to the timestamp, which is
more accurate (although not perfect), and fixes issues where the
inconsistent timings was breaking initiators.

Committed: https://crrev.com/0dec7bcceeec4f9b2283fea5040879724b9b04a5
Cr-Commit-Position: refs/heads/master@{#376187}

[droger, 2016-02-18 16:23:04]

Description was changed from

==========
tools/android/loading Ignore timings for requests coming from cache

The requests coming from Blink cache have timings that correspond to an
older request (the request that l
==========

to

==========
tools/android/loading Ignore timings for requests coming from cache

The requests coming from Blink cache have stale timings: these
are the timings corresponding to the request that put the content
in the cache, rather than of the request that got them from the cache.
==========

[droger, 2016-02-18 16:26:56]

Description was changed from

==========
tools/android/loading Ignore timings for requests coming from cache

The requests coming from Blink cache have stale timings: these
are the timings corresponding to the request that put the content
in the cache, rather than of the request that got them from the cache.
==========

to

==========
tools/android/loading Ignore timings for requests coming from cache

The requests coming from Blink cache have stale timings: these
are the timings corresponding to the request that put the content
in the cache, rather than of the request that got them from the cache.

Ignoring these timings allows to fallback to the timestamp, which is
more accurate (although not perfect), and fixes issues where the
inconsistent timings was breaking initiators.
==========

[droger, 2016-02-18 16:27:10]

droger@chromium.org changed reviewers:
+ lizeb@chromium.org

[Benoit L, 2016-02-18 16:37:36]

lgtm

https://codereview.chromium.org/1708233002/diff/20001/tools/android/loading/r...
File tools/android/loading/request_track.py (right):

https://codereview.chromium.org/1708233002/diff/20001/tools/android/loading/r...
tools/android/loading/request_track.py:495: # data URLs don't have a timing
dict, and timings for cached requests are
Maybe a TODO here, since using the timestamp is not as nice as we would like it
to be.

[droger, 2016-02-18 16:48:31]

Thanks.

https://codereview.chromium.org/1708233002/diff/20001/tools/android/loading/r...
File tools/android/loading/request_track.py (right):

https://codereview.chromium.org/1708233002/diff/20001/tools/android/loading/r...
tools/android/loading/request_track.py:495: # data URLs don't have a timing
dict, and timings for cached requests are
On 2016/02/18 16:37:36, Benoit L wrote:
> Maybe a TODO here, since using the timestamp is not as nice as we would like
it
> to be.

Done.

[droger, 2016-02-18 16:48:35]

The CQ bit was checked by droger@chromium.org

[droger, 2016-02-18 16:48:35]

The patchset sent to the CQ was uploaded after l-g-t-m from lizeb@chromium.org
Link to the patchset: https://codereview.chromium.org/1708233002/#ps40001
(title: "Review comments")

[commit-bot: I haz the power, 2016-02-18 16:49:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1708233002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1708233002/40001

[commit-bot: I haz the power, 2016-02-18 17:15:39]

Description was changed from

==========
tools/android/loading Ignore timings for requests coming from cache

The requests coming from Blink cache have stale timings: these
are the timings corresponding to the request that put the content
in the cache, rather than of the request that got them from the cache.

Ignoring these timings allows to fallback to the timestamp, which is
more accurate (although not perfect), and fixes issues where the
inconsistent timings was breaking initiators.
==========

to

==========
tools/android/loading Ignore timings for requests coming from cache

The requests coming from Blink cache have stale timings: these
are the timings corresponding to the request that put the content
in the cache, rather than of the request that got them from the cache.

Ignoring these timings allows to fallback to the timestamp, which is
more accurate (although not perfect), and fixes issues where the
inconsistent timings was breaking initiators.
==========

[commit-bot: I haz the power, 2016-02-18 17:15:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-18 17:17:13]

Description was changed from

==========
tools/android/loading Ignore timings for requests coming from cache

The requests coming from Blink cache have stale timings: these
are the timings corresponding to the request that put the content
in the cache, rather than of the request that got them from the cache.

Ignoring these timings allows to fallback to the timestamp, which is
more accurate (although not perfect), and fixes issues where the
inconsistent timings was breaking initiators.
==========

to

==========
tools/android/loading Ignore timings for requests coming from cache

The requests coming from Blink cache have stale timings: these
are the timings corresponding to the request that put the content
in the cache, rather than of the request that got them from the cache.

Ignoring these timings allows to fallback to the timestamp, which is
more accurate (although not perfect), and fixes issues where the
inconsistent timings was breaking initiators.

Committed: https://crrev.com/0dec7bcceeec4f9b2283fea5040879724b9b04a5
Cr-Commit-Position: refs/heads/master@{#376187}
==========

[commit-bot: I haz the power, 2016-02-18 17:17:14]

Patchset 3 (id:??) landed as
https://crrev.com/0dec7bcceeec4f9b2283fea5040879724b9b04a5
Cr-Commit-Position: refs/heads/master@{#376187}