Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1707173003: tools/android/loading Add 'redirect' and 'ping' content types. (Closed)

Created:
4 years, 10 months ago by droger
Modified:
4 years, 10 months ago
Reviewers:
Benoit L
CC:
chromium-reviews, gabadie+watch_chromium.org, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/android/loading Add 'redirect' and 'ping' content types. Committed: https://crrev.com/af41852675231437476a78d79d2a564a44f8b507 Cr-Commit-Position: refs/heads/master@{#376152}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Review comments #

Patch Set 3 : indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -17 lines) Patch
M tools/android/loading/model_graph.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/android/loading/request_track.py View 1 2 2 chunks +26 lines, -16 lines 0 comments Download
M tools/android/loading/request_track_unittest.py View 1 chunk +22 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
droger
4 years, 10 months ago (2016-02-18 10:52:57 UTC) #6
Benoit L
https://codereview.chromium.org/1707173003/diff/80001/tools/android/loading/request_track.py File tools/android/loading/request_track.py (right): https://codereview.chromium.org/1707173003/diff/80001/tools/android/loading/request_track.py#newcode182 tools/android/loading/request_track.py:182: """Gets the value of a HTTP response header. docstrings ...
4 years, 10 months ago (2016-02-18 11:01:27 UTC) #7
droger
All done, thanks.
4 years, 10 months ago (2016-02-18 11:09:29 UTC) #8
Benoit L
lgtm
4 years, 10 months ago (2016-02-18 12:24:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707173003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707173003/120001
4 years, 10 months ago (2016-02-18 12:27:03 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:120001)
4 years, 10 months ago (2016-02-18 12:54:11 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 12:55:43 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/af41852675231437476a78d79d2a564a44f8b507
Cr-Commit-Position: refs/heads/master@{#376152}

Powered by Google App Engine
This is Rietveld 408576698