Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1708033002: [Extensions] Don't allow chrome.browserAction.openPopup on popups (Closed)

Created:
4 years, 10 months ago by Devlin
Modified:
4 years, 10 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

[Extensions] Don't allow chrome.browserAction.openPopup on popups chrome.browserAction.openPopup opens the browser action's popup, but on a popup window, there is no browser action, and this results in a crash. Fix it, and add a regression test. BUG=584747 TBR=lazyboy@chromium.org Review URL: https://codereview.chromium.org/1683433002 Cr-Commit-Position: refs/heads/master@{#374499} (cherry picked from commit ec7d228c7522b6e16ef78965924237de654d7f15) Committed: https://chromium.googlesource.com/chromium/src/+/0f4b0822aa6bb67ba1cea05a2d67c1512389f234

Patch Set 1 : Original CL #

Patch Set 2 : Compile fix #

Messages

Total messages: 2 (1 generated)
Devlin
4 years, 10 months ago (2016-02-18 00:04:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0f4b0822aa6bb67ba1cea05a2d67c1512389f234 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698