[Extensions] Don't allow chrome.browserAction.openPopup on popups

[Extensions] Don't allow chrome.browserAction.openPopup on popups

chrome.browserAction.openPopup opens the browser action's popup, but on a
popup window, there is no browser action, and this results in a crash. Fix it,
and add a regression test.

BUG=584747
Committed: https://crrev.com/ec7d228c7522b6e16ef78965924237de654d7f15
Cr-Commit-Position: refs/heads/master@{#374499}

[Devlin, 2016-02-08 22:46:19]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-02-08 22:46:56]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2016-02-08 22:46:56]

Istiaque, mind taking a quick look?

[lazyboy, 2016-02-09 00:06:11]

lgtm with nits.

https://codereview.chromium.org/1683433002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
(right):

https://codereview.chromium.org/1683433002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/extension_action/browser_action_apitest.cc:756: //
is no toolbar (e.g., for popup windows).
Took me a while to figure this one out.

Too many "popup"s...

Can you be more explicit about which popups are which. You probably have better
idea to word them properly:
e.g. "and show a popup" -> "and show a browser action API popup"
     "for popup windows" -> for browser popup windows.

https://codereview.chromium.org/1683433002/diff/20001/chrome/test/data/extens...
File
chrome/test/data/extensions/api_test/browser_action/open_popup_on_reply/manifest.json
(right):

https://codereview.chromium.org/1683433002/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/browser_action/open_popup_on_reply/manifest.json:6:
"incognito": "spanning",
Is this required? Remove if not.

[Devlin, 2016-02-09 01:19:52]

https://codereview.chromium.org/1683433002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
(right):

https://codereview.chromium.org/1683433002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/extension_action/browser_action_apitest.cc:756: //
is no toolbar (e.g., for popup windows).
On 2016/02/09 00:06:10, lazyboy wrote:
> Took me a while to figure this one out.
> 
> Too many "popup"s...
> 
> Can you be more explicit about which popups are which. You probably have
better
> idea to word them properly:
> e.g. "and show a popup" -> "and show a browser action API popup"
>      "for popup windows" -> for browser popup windows.

Done.

https://codereview.chromium.org/1683433002/diff/20001/chrome/test/data/extens...
File
chrome/test/data/extensions/api_test/browser_action/open_popup_on_reply/manifest.json
(right):

https://codereview.chromium.org/1683433002/diff/20001/chrome/test/data/extens...
chrome/test/data/extensions/api_test/browser_action/open_popup_on_reply/manifest.json:6:
"incognito": "spanning",
On 2016/02/09 00:06:10, lazyboy wrote:
> Is this required? Remove if not.

Good call. Done.

[Devlin, 2016-02-09 17:38:09]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-02-09 17:38:09]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/1683433002/#ps40001
(title: "lazyboy's")

[commit-bot: I haz the power, 2016-02-09 17:39:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1683433002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1683433002/40001

[Devlin, 2016-02-09 17:41:48]

The CQ bit was unchecked by rdevlin.cronin@chromium.org

[Devlin, 2016-02-09 21:24:10]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-02-09 21:24:10]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/1683433002/#ps60001
(title: "Mac fix")

[commit-bot: I haz the power, 2016-02-09 21:26:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1683433002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1683433002/60001

[commit-bot: I haz the power, 2016-02-09 22:17:19]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-02-09 22:18:54]

Description was changed from

==========
[Extensions] Don't allow chrome.browserAction.openPopup on popups

chrome.browserAction.openPopup opens the browser action's popup, but on a
popup window, there is no browser action, and this results in a crash. Fix it,
and add a regression test.

BUG=584747
==========

to

==========
[Extensions] Don't allow chrome.browserAction.openPopup on popups

chrome.browserAction.openPopup opens the browser action's popup, but on a
popup window, there is no browser action, and this results in a crash. Fix it,
and add a regression test.

BUG=584747

Committed: https://crrev.com/ec7d228c7522b6e16ef78965924237de654d7f15
Cr-Commit-Position: refs/heads/master@{#374499}
==========

[commit-bot: I haz the power, 2016-02-09 22:18:55]

Patchset 3 (id:??) landed as
https://crrev.com/ec7d228c7522b6e16ef78965924237de654d7f15
Cr-Commit-Position: refs/heads/master@{#374499}