chrome/test/data/extensions/api_test/browser_action/open_popup_on_reply/background.js - Issue 1708033002: [Extensions] Don't allow chrome.browserAction.openPopup on popups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/browser_action/open_popup_on_reply/background.js

Issue 1708033002: [Extensions] Don't allow chrome.browserAction.openPopup on popups (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2623

Patch Set: Compile fix Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_action_api.cc ('k') | chrome/test/data/extensions/api_test/browser_action/open_popup_on_reply/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/browser_action/open_popup_on_reply/background.js

diff --git a/chrome/test/data/extensions/api_test/browser_action/rect_icon/background.js b/chrome/test/data/extensions/api_test/browser_action/open_popup_on_reply/background.js

similarity index 62%

copy from chrome/test/data/extensions/api_test/browser_action/rect_icon/background.js

copy to chrome/test/data/extensions/api_test/browser_action/open_popup_on_reply/background.js

index 6a9b1efb46ea06b07fe99e7d53b7049d2b7cde79..b823593ead067aa646a3339cbb72627b1d8fad32 100644

--- a/chrome/test/data/extensions/api_test/browser_action/rect_icon/background.js

+++ b/chrome/test/data/extensions/api_test/browser_action/open_popup_on_reply/background.js

@@ -3,8 +3,8 @@

// found in the LICENSE file.

chrome.test.sendMessage('ready', function() {

- chrome.browserAction.setIcon({path: 'rectangle.png'}, function() {

- chrome.test.assertNoLastError();

- chrome.test.succeed();

+ chrome.browserAction.openPopup(function(popup) {

+ chrome.test.assertFalse(!!popup);

+ chrome.test.notifyPass();

});