Issue 170783015: recipes: Stop passing --target-arch to envsetup now that it's ignored.

Issue 170783015: recipes: Stop passing --target-arch to envsetup now that it's ignored. (Closed)

Created:
6 years, 10 months ago by Nico

Modified:
6 years, 10 months ago

Reviewers:
iannucci

CC:
chromium-reviews, cmp-cc_chromium.org, kjellander+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/

Visibility:
Public.

More Reviews

Description

recipes: Stop passing --target-arch to envsetup now that it's ignored. (See r252034). BUG=330631 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=252111

Patch Set 2 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -64 lines)			Patch
M	build/scripts/slave/recipe_modules/base_android/api.py	View	1	2 chunks	+0 lines, -11 lines	0 comments	Download
M	build/scripts/slave/recipe_modules/chromium_android/api.py	View	1	2 chunks	+0 lines, -11 lines	0 comments	Download
M	build/scripts/slave/recipes/android/android_builder.expected/clang_builder.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/android/android_builder.expected/component_builder.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/android/android_builder.expected/dartium_builder.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/android/android_builder.expected/klp_builder.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/android/android_builder.expected/main_builder.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/android/android_builder.expected/mips_builder.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/android/android_builder.expected/try_builder.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/android/android_builder.expected/x86_builder.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/android/android_builder.expected/x86_try_builder.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/android/instrumentation_tests.expected/clang_tests.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/android/instrumentation_tests.expected/enormous_tests.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/android/instrumentation_tests.expected/main_tests.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/android/instrumentation_tests.expected/main_tests_deploy_fail.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/android/instrumentation_tests.expected/main_tests_device_status_check_fail.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/android/instrumentation_tests.expected/main_tests_provision_fail.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/android/instrumentation_tests.expected/try_instrumentation_tests.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/android/instrumentation_tests.expected/x86_try_instrumentation_tests.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/webrtc_android_apk_trybot.expected/Debug_arm.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/webrtc_android_apk_trybot.expected/Debug_intel.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/webrtc_android_apk_trybot.expected/Release_arm.json	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	build/scripts/slave/recipes/webrtc_android_apk_trybot.expected/Release_intel.json	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

iannucci

didn't publish comments https://codereview.chromium.org/170783015/diff/1/build/scripts/slave/recipe_modules/base_android/api.py File build/scripts/slave/recipe_modules/base_android/api.py (right): https://codereview.chromium.org/170783015/diff/1/build/scripts/slave/recipe_modules/base_android/api.py#newcode30 build/scripts/slave/recipe_modules/base_android/api.py:30: def target_arch(self): This method may be ...

6 years, 10 months ago (2014-02-19 21:54:20 UTC) #3

Nico

Removed the two target_arch() functions. https://codereview.chromium.org/170783015/diff/1/build/scripts/slave/recipe_modules/base_android/api.py File build/scripts/slave/recipe_modules/base_android/api.py (right): https://codereview.chromium.org/170783015/diff/1/build/scripts/slave/recipe_modules/base_android/api.py#newcode30 build/scripts/slave/recipe_modules/base_android/api.py:30: def target_arch(self): On 2014/02/19 ...

6 years, 10 months ago (2014-02-19 22:00:51 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/170783015/80001

6 years, 10 months ago (2014-02-19 22:09:05 UTC) #6

Message was sent while issue was closed.

Change committed as 252111

Expand Messages | Collapse Messages