recipes: Stop passing --target-arch to envsetup now that it's ignored.

build/scripts/slave/recipe_modules/chromium_android/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from slave import recipe_api
 
 class AndroidApi(recipe_api.RecipeApi):
   def __init__(self, **kwargs):
     super(AndroidApi, self).__init__(**kwargs)
     self._env = dict()
@@ skipping 89 matching lines @@
       yield self.m.step(
           'get_internal_names',
           [self.c.internal_dir('build', 'dump_internal_names.py'),
            '--output-json', self.m.json.output()]
       )
 
       self._internal_names = self.m.step_history.last_step().json.output
 
   def envsetup(self):
     envsetup_cmd = [self.m.path.checkout('build', 'android', 'envsetup.sh')]
-    if self.target_arch:
-      envsetup_cmd += ['--target-arch=%s' % self.target_arch]
 
     cmd = ([self.m.path.build('scripts', 'slave', 'env_dump.py'),
             '--output-json', self.m.json.output()] + envsetup_cmd)
 
     def update_self_env(step_result):
       env_diff = step_result.json.output
       for key, value in env_diff.iteritems():
         if key.startswith('GYP_'):
           continue
         else:
@@ skipping 199 matching lines @@
             [self.m.path.checkout('build', 'android', 'asan_symbolize.py'),
              '-l', log_file], always_run=True, env=self.get_env())
 
   @property
   def target_arch(self):
     """Convert from recipe arch to android arch."""
     return {
       'intel': 'x86',
       'arm':   'arm',
       'mips':  'mips',
     }.get(self.m.chromium.c.TARGET_ARCH, '')

[iannucci, 2014/02/19 21:54:20]

Same here... yay dups :(

 
   def test_report(self):
     return self.m.python.inline(
         'test_report',
          """
             import glob, os, sys
             for report in glob.glob(sys.argv[1]):
               with open(report, 'r') as f:
                 for l in f.readlines():
                   print l
@@ skipping 19 matching lines @@
 
   def common_tests_setup_steps(self):
     yield self.spawn_logcat_monitor()
     yield self.detect_and_setup_devices()
 
   def common_tests_final_steps(self):
     yield self.logcat_dump()
     yield self.stack_tool_steps()
     yield self.test_report()
     yield self.cleanup_build()