build/scripts/slave/recipe_modules/chromium_android/api.py - Issue 170783015: recipes: Stop passing --target-arch to envsetup now that it's ignored.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/scripts/slave/recipe_modules/chromium_android/api.py

Issue 170783015: recipes: Stop passing --target-arch to envsetup now that it's ignored. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/scripts/slave/recipe_modules/base_android/api.py ('k') | build/scripts/slave/recipes/android/android_builder.expected/clang_builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/scripts/slave/recipe_modules/chromium_android/api.py

===================================================================

--- build/scripts/slave/recipe_modules/chromium_android/api.py (revision 252098)

+++ build/scripts/slave/recipe_modules/chromium_android/api.py (working copy)

@@ -107,8 +107,6 @@

def envsetup(self):

envsetup_cmd = [self.m.path.checkout('build', 'android', 'envsetup.sh')]

- if self.target_arch:

- envsetup_cmd += ['--target-arch=%s' % self.target_arch]

cmd = ([self.m.path.build('scripts', 'slave', 'env_dump.py'),

'--output-json', self.m.json.output()] + envsetup_cmd)

@@ -321,15 +319,6 @@

[self.m.path.checkout('build', 'android', 'asan_symbolize.py'),

'-l', log_file], always_run=True, env=self.get_env())

- @property

- def target_arch(self):

- """Convert from recipe arch to android arch."""

- return {

- 'intel': 'x86',

- 'arm': 'arm',

- 'mips': 'mips',

- }.get(self.m.chromium.c.TARGET_ARCH, '')

def test_report(self):

return self.m.python.inline(

'test_report',