Always call into the embedder for password autofill auth if password uses it.

Always call into the embedder for password autofill auth if password uses it.

This will allow the embedder to change the autofill authentication based on
whether the functionality is available but has been turned off.

BUG=341492
R=gcasto@chromium.org, isherman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251892

[Ted C, 2014-02-18 19:07:53]

@gcasto||isherman - PTAL thanks!

[Garrett Casto, 2014-02-18 21:32:09]

https://codereview.chromium.org/170783005/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/chrome_password_manager_client.cc (left):

https://codereview.chromium.org/170783005/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/chrome_password_manager_client.cc:95:
::IsAutofillPasswordAuthenticationEnabled()) {
Is there any reason for this function to still exist?

[Ted C, 2014-02-18 21:38:07]

https://codereview.chromium.org/170783005/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/chrome_password_manager_client.cc (left):

https://codereview.chromium.org/170783005/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/chrome_password_manager_client.cc:95:
::IsAutofillPasswordAuthenticationEnabled()) {
On 2014/02/18 21:32:10, Garrett Casto wrote:
> Is there any reason for this function to still exist?

We use that function for checking whether or not to show the "additional
authentication" checkbox in the infobar.

[Garrett Casto, 2014-02-18 22:42:12]

https://codereview.chromium.org/170783005/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/chrome_password_manager_client.cc (left):

https://codereview.chromium.org/170783005/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/chrome_password_manager_client.cc:95:
::IsAutofillPasswordAuthenticationEnabled()) {
On 2014/02/18 21:38:07, Ted C wrote:
> On 2014/02/18 21:32:10, Garrett Casto wrote:
> > Is there any reason for this function to still exist?
> 
> We use that function for checking whether or not to show the "additional
> authentication" checkbox in the infobar.

Do you mean SavePasswordInfoBar.java? It looks like that references the Java
PasswordAuthenticationManager, not the C++ class.

[Ted C, 2014-02-18 22:49:25]

On 2014/02/18 22:42:12, Garrett Casto wrote:
>
https://codereview.chromium.org/170783005/diff/1/chrome/browser/password_mana...
> File chrome/browser/password_manager/chrome_password_manager_client.cc (left):
> 
>
https://codereview.chromium.org/170783005/diff/1/chrome/browser/password_mana...
> chrome/browser/password_manager/chrome_password_manager_client.cc:95:
> ::IsAutofillPasswordAuthenticationEnabled()) {
> On 2014/02/18 21:38:07, Ted C wrote:
> > On 2014/02/18 21:32:10, Garrett Casto wrote:
> > > Is there any reason for this function to still exist?
> > 
> > We use that function for checking whether or not to show the "additional
> > authentication" checkbox in the infobar.
> 
> Do you mean SavePasswordInfoBar.java? It looks like that references the Java
> PasswordAuthenticationManager, not the C++ class.

Ah yes, you are right.  I uploaded a patch that removes it from C++ land.

[Garrett Casto, 2014-02-18 23:10:48]

lgtm

[Ted C, 2014-02-18 23:13:20]

The CQ bit was checked by tedchoc@chromium.org

[Ilya Sherman, 2014-02-18 23:13:52]

lgtm2

[commit-bot: I haz the power, 2014-02-18 23:14:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tedchoc@chromium.org/170783005/70005

[commit-bot: I haz the power, 2014-02-19 00:12:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-19 00:12:54]

Try jobs failed on following builders: mac_chromium_rel

[Ted C, 2014-02-19 00:14:48]

Committed patchset #3 manually as r251892 (presubmit successful).