chrome/browser/android/password_authentication_manager.cc - Issue 170783005: Always call into the embedder for password autofill auth if password uses it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/password_authentication_manager.cc

Issue 170783005: Always call into the embedder for password autofill auth if password uses it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove assert in requestAuthentication. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/password_authentication_manager.h ('k') | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/password_authentication_manager.cc

diff --git a/chrome/browser/android/password_authentication_manager.cc b/chrome/browser/android/password_authentication_manager.cc

index 76f0d4d71ca89dfb6edaf4f05c5190277576ae92..700707571ae67944c4e491b6eceda252f28e551d 100644

--- a/chrome/browser/android/password_authentication_manager.cc

+++ b/chrome/browser/android/password_authentication_manager.cc

@@ -41,11 +41,6 @@ bool PasswordAuthenticationManager::RegisterPasswordAuthenticationManager(

return RegisterNativesImpl(env);

}

-bool PasswordAuthenticationManager::IsAutofillPasswordAuthenticationEnabled() {

- return Java_PasswordAuthenticationManager_isPasswordAuthenticationEnabled(

- base::android::AttachCurrentThread());

void PasswordAuthenticationManager::AuthenticatePasswordAutofill(

content::WebContents* web_contents,

const base::Closure& success_callback) {