chrome/android/java/src/org/chromium/chrome/browser/password_manager/PasswordAuthenticationManager.java - Issue 170783005: Always call into the embedder for password autofill auth if password uses it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/password_manager/PasswordAuthenticationManager.java

Issue 170783005: Always call into the embedder for password autofill auth if password uses it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove assert in requestAuthentication. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/password_manager/PasswordAuthenticationManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/password_manager/PasswordAuthenticationManager.java b/chrome/android/java/src/org/chromium/chrome/browser/password_manager/PasswordAuthenticationManager.java

index 729eae6ce8fc290469fed67102b911302f1d2490..355c30cb176458fa71e080dab7a686155e0777c5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/password_manager/PasswordAuthenticationManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/password_manager/PasswordAuthenticationManager.java

@@ -73,7 +73,6 @@ public class PasswordAuthenticationManager {

@Override

public void requestAuthentication(TabBase tab, PasswordAuthenticationCallback callback) {

- assert false : "Should check isAuthenticationRequiredForUrl before calling this.";

callback.onResult(true);

}

@@ -104,7 +103,6 @@ public class PasswordAuthenticationManager {

/**

* @return Whether password authentication is enabled.

- @CalledByNative

public static boolean isPasswordAuthenticationEnabled() {

return getDelegate().isPasswordAuthenticationEnabled();

}

« no previous file with comments | « no previous file | chrome/browser/android/password_authentication_manager.h » ('j') | no next file with comments »