Add check so WIN_FASTLINK will be ignored on VS 2013

Add check so WIN_FASTLINK will be ignored on VS 2013

win_fastlink is helpful for improving build speeds with VS 2015 but is
not supported on VS 2013. To make it easier to enable this flag it needs
to be silently ignored by VS 2013. This makes that happen.

BUG=440500
Committed: https://crrev.com/6b851bfe96519bca59237b79a003df41dcf98c3b
Cr-Commit-Position: refs/heads/master@{#375999}

[brucedawson, 2016-02-17 19:12:44]

brucedawson@chromium.org changed reviewers:
+ scottmg@chromium.org

[brucedawson, 2016-02-17 19:12:44]

This falls into the "obvious in hindsight" category. It is easier for developers
to use fastlink if it doesn't break VS 2013 builds. This adds version checks to
the gyp and gn files so that fastlink can be set-and-forget now.

[scottmg, 2016-02-17 19:14:02]

lgtm

https://codereview.chromium.org/1707813002/diff/40001/build/config/compiler/B...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1707813002/diff/40001/build/config/compiler/B...
build/config/compiler/BUILD.gn:1269: if (is_win_fastlink &&
visual_studio_version == "2015") {
!= "2013" maybe?

[brucedawson, 2016-02-17 19:53:01]

https://codereview.chromium.org/1707813002/diff/40001/build/config/compiler/B...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1707813002/diff/40001/build/config/compiler/B...
build/config/compiler/BUILD.gn:1269: if (is_win_fastlink &&
visual_studio_version == "2015") {
On 2016/02/17 19:14:02, scottmg wrote:
> != "2013" maybe?

Yeah, I decided to make that change. Possibly more long-term stable?

[brucedawson, 2016-02-17 20:34:07]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2016-02-17 20:34:07]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1707813002/#ps60001
(title: "Changed from == 2015 to != 2013")

[commit-bot: I haz the power, 2016-02-17 20:38:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1707813002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1707813002/60001

[commit-bot: I haz the power, 2016-02-17 22:13:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-17 22:14:44]

Description was changed from

==========
Add check so WIN_FASTLINK will be ignored on VS 2013

win_fastlink is helpful for improving build speeds with VS 2015 but is
not supported on VS 2013. To make it easier to enable this flag it needs
to be silently ignored by VS 2013. This makes that happen.

BUG=440500
==========

to

==========
Add check so WIN_FASTLINK will be ignored on VS 2013

win_fastlink is helpful for improving build speeds with VS 2015 but is
not supported on VS 2013. To make it easier to enable this flag it needs
to be silently ignored by VS 2013. This makes that happen.

BUG=440500

Committed: https://crrev.com/6b851bfe96519bca59237b79a003df41dcf98c3b
Cr-Commit-Position: refs/heads/master@{#375999}
==========

[commit-bot: I haz the power, 2016-02-17 22:14:45]

Patchset 4 (id:??) landed as
https://crrev.com/6b851bfe96519bca59237b79a003df41dcf98c3b
Cr-Commit-Position: refs/heads/master@{#375999}

[Fady Samuel, 2016-02-18 01:56:51]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1708073002/ by fsamuel@chromium.org.

The reason for reverting is: Speculative revert:
https://code.google.com/p/chromium/issues/detail?id=587687.