Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Side by Side Diff: build/common.gypi

Issue 1707813002: Add check so WIN_FASTLINK will be ignored on VS 2013 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed from == 2015 to != 2013 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3250 matching lines...) Expand 10 before | Expand all | Expand 10 after
3261 'AdditionalOptions': [ 3261 'AdditionalOptions': [
3262 # Suggested by Microsoft Devrel to avoid 3262 # Suggested by Microsoft Devrel to avoid
3263 # LINK : fatal error LNK1248: image size (80000000) exceeds maxi mum allowable size (80000000) 3263 # LINK : fatal error LNK1248: image size (80000000) exceeds maxi mum allowable size (80000000)
3264 # which started happening more regularly after VS2013 Update 4. 3264 # which started happening more regularly after VS2013 Update 4.
3265 # Needs to be a bit lower for VS2015, or else errors out. 3265 # Needs to be a bit lower for VS2015, or else errors out.
3266 '/maxilksize:0x7ff00000', 3266 '/maxilksize:0x7ff00000',
3267 ], 3267 ],
3268 }, 3268 },
3269 }, 3269 },
3270 'conditions': [ 3270 'conditions': [
3271 ['OS=="win" and win_fastlink==1', { 3271 ['OS=="win" and win_fastlink==1 and MSVS_VERSION != "2013"', {
3272 'msvs_settings': { 3272 'msvs_settings': {
3273 'VCLinkerTool': { 3273 'VCLinkerTool': {
3274 # /PROFILE is incompatible with /debug:fastlink 3274 # /PROFILE is incompatible with /debug:fastlink
3275 'Profile': 'false', 3275 'Profile': 'false',
3276 'AdditionalOptions': [ 3276 'AdditionalOptions': [
3277 # Tell VS 2015+ to create a PDB that references debug 3277 # Tell VS 2015+ to create a PDB that references debug
3278 # information in .obj and .lib files instead of copying 3278 # information in .obj and .lib files instead of copying
3279 # it all. 3279 # it all.
3280 '/DEBUG:FASTLINK', 3280 '/DEBUG:FASTLINK',
3281 ], 3281 ],
(...skipping 3118 matching lines...) Expand 10 before | Expand all | Expand 10 after
6400 # settings in target dicts. SYMROOT is a special case, because many other 6400 # settings in target dicts. SYMROOT is a special case, because many other
6401 # Xcode variables depend on it, including variables such as 6401 # Xcode variables depend on it, including variables such as
6402 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6402 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6403 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6403 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6404 # files to appear (when present) in the UI as actual files and not red 6404 # files to appear (when present) in the UI as actual files and not red
6405 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6405 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6406 # and therefore SYMROOT, needs to be set at the project level. 6406 # and therefore SYMROOT, needs to be set at the project level.
6407 'SYMROOT': '<(DEPTH)/xcodebuild', 6407 'SYMROOT': '<(DEPTH)/xcodebuild',
6408 }, 6408 },
6409 } 6409 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698