build/config/compiler/BUILD.gn - Issue 1707813002: Add check so WIN_FASTLINK will be ignored on VS 2013

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1707813002: Add check so WIN_FASTLINK will be ignored on VS 2013 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed from == 2015 to != 2013 Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index b1afcca5f9230719bbdab5b4cae92e1f9ae6bcf9..c2461159e7ed32652ac7070468c497dd7f696bbd 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -1266,7 +1266,7 @@ config("symbols") {

} else {

cflags = [ "/Zi" ] # Produce PDB file, no edit and continue.

}

- if (is_win_fastlink) {

+ if (is_win_fastlink && visual_studio_version != "2013") {

# Tell VS 2015+ to create a PDB that references debug

# information in .obj and .lib files instead of copying

# it all. This flag is incompatible with /PROFILE

@@ -1289,7 +1289,7 @@ config("minimal_symbols") {

if (is_win) {

# Linker symbols for backtraces only.

cflags = []

- if (is_win_fastlink) {

+ if (is_win_fastlink && visual_studio_version != "2013") {

# Tell VS 2015+ to create a PDB that references debug

# information in .obj and .lib files instead of copying

# it all. This flag is incompatible with /PROFILE

« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »