Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1707733002: StartupUtils: Improve docs and move static functions to anonymous namespace. (Closed)

Created:
4 years, 10 months ago by Thiemo Nagel
Modified:
4 years, 10 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, Denis Kuznetsov (DE-MUC)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

StartupUtils: Improve docs and move static functions to anonymous namespace. Moving static functions to anonymous namespace for more modern style and better readability. BUG=587495 Committed: https://crrev.com/9ac8d6059b4bf06bbbc383fbbeb72182c9a06394 Cr-Commit-Position: refs/heads/master@{#376121}

Patch Set 1 #

Patch Set 2 : Update docs after discussion with antrim. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -31 lines) Patch
M chrome/browser/chromeos/login/startup_utils.h View 1 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/startup_utils.cc View 3 chunks +29 lines, -29 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Thiemo Nagel
Hi Denis, could you please take a look? Thank you! Thiemo
4 years, 10 months ago (2016-02-17 16:33:54 UTC) #2
Thiemo Nagel
Hi Sasha, Denis has directed me to you. May I ask you to take a ...
4 years, 10 months ago (2016-02-17 17:20:45 UTC) #6
Alexander Alekseev
lgtm
4 years, 10 months ago (2016-02-17 21:46:17 UTC) #8
Thiemo Nagel
On 2016/02/17 21:46:17, Alexander Alekseev wrote: > lgtm Thank you!
4 years, 10 months ago (2016-02-18 08:07:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707733002/20001
4 years, 10 months ago (2016-02-18 08:08:26 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-18 08:50:35 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 08:51:21 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9ac8d6059b4bf06bbbc383fbbeb72182c9a06394
Cr-Commit-Position: refs/heads/master@{#376121}

Powered by Google App Engine
This is Rietveld 408576698