StartupUtils: Improve docs and move static functions to anonymous namespace.

chrome/browser/chromeos/login/startup_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/startup_utils.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/path_service.h"
@@ skipping 29 matching lines @@
 }
 
 // Saves string "Local State" preference and forces its persistence to disk.
 void SaveStringPreferenceForced(const char* pref_name,
                                 const std::string& value) {
   PrefService* prefs = g_browser_process->local_state();
   prefs->SetString(pref_name, value);
   prefs->CommitPendingWrite();
 }
 
+// Returns the path to flag file indicating that both parts of OOBE were
+// completed.
+// On chrome device, returns /home/chronos/.oobe_completed.
+// On Linux desktop, returns {DIR_USER_DATA}/.oobe_completed.
+base::FilePath GetOobeCompleteFlagPath() {
+  // The constant is defined here so it won't be referenced directly.
+  const char kOobeCompleteFlagFilePath[] = "/home/chronos/.oobe_completed";
+
+  if (base::SysInfo::IsRunningOnChromeOS()) {
+    return base::FilePath(kOobeCompleteFlagFilePath);
+  } else {
+    base::FilePath user_data_dir;
+    PathService::Get(chrome::DIR_USER_DATA, &user_data_dir);
+    return user_data_dir.AppendASCII(".oobe_completed");
+  }
+}
+
+void CreateOobeCompleteFlagFile() {
+  // Create flag file for boot-time init scripts.
+  const base::FilePath oobe_complete_flag_path = GetOobeCompleteFlagPath();
+  if (!base::PathExists(oobe_complete_flag_path)) {
+    FILE* oobe_flag_file = base::OpenFile(oobe_complete_flag_path, "w+b");
+    if (oobe_flag_file == NULL)
+      DLOG(WARNING) << oobe_complete_flag_path.value() << " doesn't exist.";
+    else
+      base::CloseFile(oobe_flag_file);
+  }
+}
+
 }  // namespace
 
 namespace chromeos {
 
 // static
 void StartupUtils::RegisterPrefs(PrefRegistrySimple* registry) {
   registry->RegisterBooleanPref(prefs::kOobeComplete, false);
   registry->RegisterStringPref(prefs::kOobeScreenPending, "");
   registry->RegisterIntegerPref(prefs::kDeviceRegistered, -1);
   registry->RegisterBooleanPref(prefs::kEnrollmentRecoveryRequired, false);
@@ skipping 25 matching lines @@
 
   // Successful enrollment implies that recovery is not required.
   SaveBoolPreferenceForced(prefs::kEnrollmentRecoveryRequired, false);
 }
 
 // static
 void StartupUtils::SaveOobePendingScreen(const std::string& screen) {
   SaveStringPreferenceForced(prefs::kOobeScreenPending, screen);
 }
 
-// Returns the path to flag file indicating that both parts of OOBE were
-// completed.
-// On chrome device, returns /home/chronos/.oobe_completed.
-// On Linux desktop, returns {DIR_USER_DATA}/.oobe_completed.
-static base::FilePath GetOobeCompleteFlagPath() {
-  // The constant is defined here so it won't be referenced directly.
-  const char kOobeCompleteFlagFilePath[] = "/home/chronos/.oobe_completed";
-
-  if (base::SysInfo::IsRunningOnChromeOS()) {
-    return base::FilePath(kOobeCompleteFlagFilePath);
-  } else {
-    base::FilePath user_data_dir;
-    PathService::Get(chrome::DIR_USER_DATA, &user_data_dir);
-    return user_data_dir.AppendASCII(".oobe_completed");
-  }
-}
-
 // static
 base::TimeDelta StartupUtils::GetTimeSinceOobeFlagFileCreation() {
   const base::FilePath oobe_complete_flag_path = GetOobeCompleteFlagPath();
   base::File::Info file_info;
   if (base::GetFileInfo(oobe_complete_flag_path, &file_info))
     return base::Time::Now() - file_info.creation_time;
   return base::TimeDelta();
 }
 
-static void CreateOobeCompleteFlagFile() {
-  // Create flag file for boot-time init scripts.
-  const base::FilePath oobe_complete_flag_path = GetOobeCompleteFlagPath();
-  if (!base::PathExists(oobe_complete_flag_path)) {
-    FILE* oobe_flag_file = base::OpenFile(oobe_complete_flag_path, "w+b");
-    if (oobe_flag_file == NULL)
-      DLOG(WARNING) << oobe_complete_flag_path.value() << " doesn't exist.";
-    else
-      base::CloseFile(oobe_flag_file);
-  }
-}
-
 // static
 bool StartupUtils::IsDeviceRegistered() {
   int value =
       g_browser_process->local_state()->GetInteger(prefs::kDeviceRegistered);
   if (value > 0) {
     // Recreate flag file in case it was lost.
     BrowserThread::PostTask(
         BrowserThread::FILE,
         FROM_HERE,
         base::Bind(&CreateOobeCompleteFlagFile));
@@ skipping 49 matching lines @@
 
 // static
 void StartupUtils::SetInitialLocale(const std::string& locale) {
   if (l10n_util::IsValidLocaleSyntax(locale))
     SaveStringPreferenceForced(prefs::kInitialLocale, locale);
   else
     NOTREACHED();
 }
 
 }  // namespace chromeos