Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: chrome/browser/chromeos/login/startup_utils.h

Issue 1707733002: StartupUtils: Improve docs and move static functions to anonymous namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update docs after discussion with antrim. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/startup_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/startup_utils.h
diff --git a/chrome/browser/chromeos/login/startup_utils.h b/chrome/browser/chromeos/login/startup_utils.h
index a4507e7db6e807003f9433bbe82cf69a5c3c1132..65e9167cea70ea4be54ce3ee5ac9018e649a6e8c 100644
--- a/chrome/browser/chromeos/login/startup_utils.h
+++ b/chrome/browser/chromeos/login/startup_utils.h
@@ -24,7 +24,9 @@ class StartupUtils {
// Returns true if EULA has been accepted.
static bool IsEulaAccepted();
- // Returns OOBE completion status.
+ // Returns OOBE completion status, i.e. whether the OOBE wizard should be run
+ // on next boot. This is NOT what causes the .oobe_completed flag file to be
+ // written.
static bool IsOobeCompleted();
// Marks EULA status as accepted.
@@ -36,10 +38,13 @@ class StartupUtils {
// Stores the next pending OOBE screen in case it will need to be resumed.
static void SaveOobePendingScreen(const std::string& screen);
- // Returns the time since the Oobe flag file was created.
+ // Returns the time since the OOBE flag file was created.
static base::TimeDelta GetTimeSinceOobeFlagFileCreation();
// Returns device registration completion status, i.e. second part of OOBE.
+ // It is triggered by enrolling the device, but also by logging in as a
+ // consumer owner or by logging in as guest. This state change is announced
+ // to the system by writing the .oobe_completed flag file.
static bool IsDeviceRegistered();
// Marks device registered. i.e. second part of OOBE is completed.
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/startup_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698