Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1706883003: Subzero. Removes X8664_STACK_HACK from the crosstests. (Closed)

Created:
4 years, 10 months ago by John
Modified:
4 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero. Removes X8664_STACK_HACK from the crosstests. X8664_STACK_HACK was an intrusive way to get the crosstests to run while x32 support was not implemented in llvm. The hack is longer needed. R=eholk@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b35615b493d426845ba91e8cdf9365e72169ccaf

Patch Set 1 #

Patch Set 2 : removes stack_hack.x8664.c #

Patch Set 3 : removes code setting the stack size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -182 lines) Patch
M crosstest/mem_intrin_main.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M crosstest/simple_loop_main.c View 1 chunk +0 lines, -4 lines 0 comments Download
M crosstest/stack_hack.x8664.c View 1 1 chunk +0 lines, -76 lines 0 comments Download
M crosstest/test_arith_main.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M crosstest/test_bitmanip_main.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M crosstest/test_calling_conv_main.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M crosstest/test_cast_main.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M crosstest/test_fcmp_main.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M crosstest/test_icmp_main.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M crosstest/test_select_main.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M crosstest/test_stacksave_main.c View 1 chunk +0 lines, -4 lines 0 comments Download
M crosstest/test_strengthreduce_main.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M crosstest/test_sync_atomic_main.cpp View 1 2 4 chunks +0 lines, -22 lines 0 comments Download
M crosstest/test_vector_ops_main.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M crosstest/xdefs.h View 1 chunk +0 lines, -29 lines 0 comments Download
M pydir/crosstest.py View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
John
4 years, 10 months ago (2016-02-17 17:41:08 UTC) #2
Eric Holk
lgtm
4 years, 10 months ago (2016-02-17 17:55:01 UTC) #3
John
4 years, 10 months ago (2016-02-17 18:16:15 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
b35615b493d426845ba91e8cdf9365e72169ccaf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698