Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: crosstest/xdefs.h

Issue 1706883003: Subzero. Removes X8664_STACK_HACK from the crosstests. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: removes code setting the stack size Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « crosstest/test_vector_ops_main.cpp ('k') | pydir/crosstest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crosstest/xdefs.h
diff --git a/crosstest/xdefs.h b/crosstest/xdefs.h
index 00a451212eb1a9ad3cbc701ee609e3770c061222..75f3a38baf5cff1a9d273bceafe11d1d5bccb438 100644
--- a/crosstest/xdefs.h
+++ b/crosstest/xdefs.h
@@ -21,33 +21,4 @@ typedef long long int64;
typedef unsigned long long uint64;
typedef unsigned int SizeT;
-#ifdef X8664_STACK_HACK
-
-// the X86_STACK_HACK is an intrusive way of getting the crosstests to run in
-// x86_64 LP64 even with an ILP32 model. This hack allocates a new stack for
-// running the tests in the low 4GB of the address space.
-
-#ifdef __cplusplus
-#define XTEST_EXTERN extern "C"
-#else // !defined(__cplusplus)
-#define XTEST_EXTERN extern
-#endif // __cplusplus
-
-/// xAllocStack allocates the memory chunk [StackEnd - Size - 1, StackEnd). It
-/// requires StackEnd to be less than 32-bits long. Conversely, xDeallocStack
-/// frees that memory chunk.
-/// {@
-XTEST_EXTERN unsigned char *xAllocStack(uint64 StackEnd, uint32 Size);
-XTEST_EXTERN void xDeallocStack(uint64 StackEnd, uint32 Size);
-/// @}
-
-// wrapped_main is invoked by the x86-64 stack hack main. We declare a prototype
-// so the compiler (and not the linker) can yell if a test's wrapped_main
-// prototype does not match what we want.
-XTEST_EXTERN int wrapped_main(int argc, char *argv[]);
-
-#undef XTEST_EXTERN
-
-#endif // X8664_STACK_HACK
-
#endif // SUBZERO_CROSSTEST_XDEFS_H_
« no previous file with comments | « crosstest/test_vector_ops_main.cpp ('k') | pydir/crosstest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698