pydir/crosstest.py - Issue 1706883003: Subzero. Removes X8664_STACK_HACK from the crosstests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pydir/crosstest.py

Issue 1706883003: Subzero. Removes X8664_STACK_HACK from the crosstests. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: removes code setting the stack size Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pydir/crosstest.py

diff --git a/pydir/crosstest.py b/pydir/crosstest.py

index 306f89401e287744e8623435d9af1d816c84c191..20cc349c568e29fc2168e436e26befa5d2fe32cd 100755

--- a/pydir/crosstest.py

+++ b/pydir/crosstest.py

@@ -199,14 +199,7 @@ def main():

).format(root=nacl_root,

sb=get_sfi_string(args, 'sb', 'nonsfi', 'native')))

- # TODO(jpp): clean up stack hack related code.

- needs_stack_hack = False

target_params = []

- if needs_stack_hack:

- shellcmd('{bin}/clang -g -o stack_hack.x8664.{key}.o -c '

- 'stack_hack.x8664.c'.format(bin=bindir, key=key))

- target_params.append('-DX8664_STACK_HACK')

- target_params.append('stack_hack.x8664.{key}.o'.format(key=key))

if args.target == 'arm32':

target_params.append('-DARM32')

« no previous file with comments | « crosstest/xdefs.h ('k') | no next file » | no next file with comments »