Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1706853002: Clean-up ProfileSyncServiceBookmarkTest (Closed)

Created:
4 years, 10 months ago by vabr (Chromium)
Modified:
4 years, 10 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@581640_move_files
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean-up ProfileSyncServiceBookmarkTest This CL removes some unused #includes and puts all test fixture data members into the private section. This is both to make the following componentisation easier, and to address proactively requests like https://codereview.chromium.org/1646553002/diff/160001/chrome/browser/sync/abstract_profile_sync_service_test.h#newcode53 before they are made in the componentisation CL. BUG=586642 Committed: https://crrev.com/227ce81f692e7656828d0ba72e3fad5d3d99ad3b Cr-Commit-Position: refs/heads/master@{#376490}

Patch Set 1 #

Patch Set 2 : Just rebased #

Patch Set 3 : Just rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -253 lines) Patch
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 77 chunks +268 lines, -253 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (10 generated)
vabr (Chromium)
Hello Pavel, PTAL. Thanks! Vaclav
4 years, 10 months ago (2016-02-17 16:05:57 UTC) #2
pavely
lgtm
4 years, 10 months ago (2016-02-17 19:15:16 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706853002/40001
4 years, 10 months ago (2016-02-19 09:43:40 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/147814)
4 years, 10 months ago (2016-02-19 09:56:10 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706853002/40001
4 years, 10 months ago (2016-02-19 13:10:36 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/147873)
4 years, 10 months ago (2016-02-19 13:26:47 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706853002/40001
4 years, 10 months ago (2016-02-19 15:58:16 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/147925)
4 years, 10 months ago (2016-02-19 16:23:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706853002/40001
4 years, 10 months ago (2016-02-19 17:49:54 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-19 18:11:32 UTC) #19
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 18:12:46 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/227ce81f692e7656828d0ba72e3fad5d3d99ad3b
Cr-Commit-Position: refs/heads/master@{#376490}

Powered by Google App Engine
This is Rietveld 408576698