Move ProfileSyncService tests for autofill & typed URLs to components

Move ProfileSyncService tests for autofill & typed URLs to components

This includes also shared test support.

BUG=581640
Committed: https://crrev.com/7e9f0b977401718795e716cc77be9d491e020118
Cr-Commit-Position: refs/heads/master@{#376474}

[vabr (Chromium), 2016-02-12 21:32:30]

Description was changed from

==========
Move ProfileSyncService tests for autofill & typed URLs to components

This includes also shared test support.

BUG=581640
==========

to

==========
Move ProfileSyncService tests for autofill & typed URLs to components

This includes also shared test support.

BUG=581640
==========

[vabr (Chromium), 2016-02-12 21:32:30]

vabr@chromium.org changed reviewers:
+ pkasting@chromium.org, sdefresne@chromium.org, zea@chromium.org

[vabr (Chromium), 2016-02-12 22:12:49]

Hello reviewers!

PTAL,

pkasting: at components/browser_sync/browser/DEPS

zea: sync code

sdefresne: gypi and GN changes

Thank you!
Vaclav

[Peter Kasting, 2016-02-13 01:26:26]

LGTM

[Nicolas Zea, 2016-02-13 01:30:35]

LGTM with a question

https://codereview.chromium.org/1692873004/diff/1/components/sync_driver.gypi
File components/sync_driver.gypi (right):

https://codereview.chromium.org/1692873004/diff/1/components/sync_driver.gypi...
components/sync_driver.gypi:25:
'../third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation',
Why is this necessary now?

[vabr (Chromium), 2016-02-13 10:43:47]

Thanks both for review!

Cheers,
Vaclav

https://codereview.chromium.org/1692873004/diff/1/components/sync_driver.gypi
File components/sync_driver.gypi (right):

https://codereview.chromium.org/1692873004/diff/1/components/sync_driver.gypi...
components/sync_driver.gypi:25:
'../third_party/cacheinvalidation/cacheinvalidation.gyp:cacheinvalidation',
On 2016/02/13 01:30:35, Nicolas Zea wrote:
> Why is this necessary now?

The invalidation headers require a special path prefix added (the -I argument of
the compiler). Without this section, the -I option gets set for compiling
sync_driver, but not any targets dependent on it, in particular not in
component_unittests. By transitivity, however, headers from cacheinvalidation
get included in files compiled for component_unittests now, and the compiler
cannot locate them without the additional -I flag.

[sdefresne, 2016-02-15 10:02:11]

lgtm

https://codereview.chromium.org/1692873004/diff/20001/components/sync_driver....
File components/sync_driver.gypi (right):

https://codereview.chromium.org/1692873004/diff/20001/components/sync_driver....
components/sync_driver.gypi:24: 'export_dependent_settings': [
nit: do you need to add //third_party/cacheinvalidation to public_deps of
//components/sync_driver?

[vabr (Chromium), 2016-02-16 08:56:42]

I forgot to publish that I addressed sdefresne@'s comment yesterday.

The failing ASAN is the issue from https://codereview.chromium.org/1684643002/,
which I'm fixing there. Once rebased, it should become green.

Cheers,
Vaclav

https://codereview.chromium.org/1692873004/diff/20001/components/sync_driver....
File components/sync_driver.gypi (right):

https://codereview.chromium.org/1692873004/diff/20001/components/sync_driver....
components/sync_driver.gypi:24: 'export_dependent_settings': [
On 2016/02/15 10:02:10, sdefresne wrote:
> nit: do you need to add //third_party/cacheinvalidation to public_deps of
> //components/sync_driver?

Done.

[vabr (Chromium), 2016-02-19 09:30:26]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 09:30:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1692873004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1692873004/140001

[vabr (Chromium), 2016-02-19 11:08:42]

The CQ bit was unchecked by vabr@chromium.org

[vabr (Chromium), 2016-02-19 11:08:42]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-02-19 11:08:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, zea@chromium.org, sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/1692873004/#ps140001
(title: "Just rebased")

[commit-bot: I haz the power, 2016-02-19 11:09:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 11:09:38]

This CL has an open dependency (Issue 1684643002 Patch 320001). Please resolve
the dependency and try again.

[vabr (Chromium), 2016-02-19 11:41:46]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 11:43:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1692873004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1692873004/140001

[vabr (Chromium), 2016-02-19 13:07:15]

The CQ bit was unchecked by vabr@chromium.org

[vabr (Chromium), 2016-02-19 15:54:47]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 15:58:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1692873004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1692873004/140001

[commit-bot: I haz the power, 2016-02-19 17:07:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 17:08:00]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-02-19 17:09:36]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-02-19 17:12:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1692873004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1692873004/140001

[commit-bot: I haz the power, 2016-02-19 17:24:29]

Description was changed from

==========
Move ProfileSyncService tests for autofill & typed URLs to components

This includes also shared test support.

BUG=581640
==========

to

==========
Move ProfileSyncService tests for autofill & typed URLs to components

This includes also shared test support.

BUG=581640
==========

[commit-bot: I haz the power, 2016-02-19 17:24:31]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-02-19 17:25:23]

Description was changed from

==========
Move ProfileSyncService tests for autofill & typed URLs to components

This includes also shared test support.

BUG=581640
==========

to

==========
Move ProfileSyncService tests for autofill & typed URLs to components

This includes also shared test support.

BUG=581640

Committed: https://crrev.com/7e9f0b977401718795e716cc77be9d491e020118
Cr-Commit-Position: refs/heads/master@{#376474}
==========

[commit-bot: I haz the power, 2016-02-19 17:25:25]

Patchset 8 (id:??) landed as
https://crrev.com/7e9f0b977401718795e716cc77be9d491e020118
Cr-Commit-Position: refs/heads/master@{#376474}