Remove //chrome and //content deps from ProfileSyncServiceBookmarkTest

Remove //chrome and //content deps from ProfileSyncServiceBookmarkTest

BUG=586642
Committed: https://crrev.com/0b75a3459bf4e7148230a43b2c42d30a4e0572c2
Cr-Commit-Position: refs/heads/master@{#376960}

[vabr (Chromium), 2016-02-19 16:38:37]

Patchset #2 (id:20001) has been deleted

[vabr (Chromium), 2016-02-19 16:38:46]

Patchset #1 (id:1) has been deleted

[vabr (Chromium), 2016-02-19 16:42:30]

Patchset #1 (id:40001) has been deleted

[vabr (Chromium), 2016-02-19 16:43:08]

Description was changed from

==========
[WIP] Remove //chrome and //content deps from ProfileSyncServiceBookmarkTest

WIP: This is not finished and not ready for review yet.
COMMIT=false

BUG=586642
==========

to

==========
Remove //chrome and //content deps from ProfileSyncServiceBookmarkTest

BUG=586642
==========

[vabr (Chromium), 2016-02-19 16:43:08]

Description was changed from

==========
[WIP] Remove //chrome and //content deps from ProfileSyncServiceBookmarkTest

WIP: This is not finished and not ready for review yet.
COMMIT=false

BUG=586642
==========

to

==========
Remove //chrome and //content deps from ProfileSyncServiceBookmarkTest

BUG=586642
==========

[vabr (Chromium), 2016-02-19 22:10:29]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 22:13:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705813002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705813002/140001

[commit-bot: I haz the power, 2016-02-19 22:31:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 22:31:32]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[vabr (Chromium), 2016-02-19 22:55:42]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 22:58:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705813002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705813002/160001

[vabr (Chromium), 2016-02-19 22:58:48]

vabr@chromium.org changed reviewers:
+ sky@chromium.org, zea@chromium.org

[vabr (Chromium), 2016-02-19 22:58:48]

Hello reviewers!

@sky -- please review adding bookmarks into components/browser_sync/browser/DEPS

@zea -- please review the whole CL

Thanks!
Vaclav

[commit-bot: I haz the power, 2016-02-19 23:20:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 23:20:17]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sky, 2016-02-19 23:26:00]

LGTM

[vabr (Chromium), 2016-02-22 09:09:06]

Thanks, sky@, for the DEPS review.

Nicolas: I realised I missed some GYP dependencies, so added them in patch set 8
(with a plain rebase in p.s. 7). No other changes since the first call for
review done.

Cheers,
Vaclav

[Nicolas Zea, 2016-02-22 18:32:39]

LGTM

https://codereview.chromium.org/1705813002/diff/200001/chrome/browser/sync/pr...
File chrome/browser/sync/profile_sync_service_bookmark_unittest.cc (right):

https://codereview.chromium.org/1705813002/diff/200001/chrome/browser/sync/pr...
chrome/browser/sync/profile_sync_service_bookmark_unittest.cc:444: // will be
deleted.
nit for clarity: will be deleted before starting up the BookmarkModel.

[vabr (Chromium), 2016-02-23 08:40:17]

Thanks!

Sending to CQ now.

Cheers,
Vaclav

https://codereview.chromium.org/1705813002/diff/200001/chrome/browser/sync/pr...
File chrome/browser/sync/profile_sync_service_bookmark_unittest.cc (right):

https://codereview.chromium.org/1705813002/diff/200001/chrome/browser/sync/pr...
chrome/browser/sync/profile_sync_service_bookmark_unittest.cc:444: // will be
deleted.
On 2016/02/22 18:32:39, Nicolas Zea wrote:
> nit for clarity: will be deleted before starting up the BookmarkModel.

Done.

[vabr (Chromium), 2016-02-23 08:40:31]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-02-23 08:40:32]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
zea@chromium.org
Link to the patchset: https://codereview.chromium.org/1705813002/#ps220001
(title: "Improve comment")

[commit-bot: I haz the power, 2016-02-23 08:41:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705813002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705813002/220001

[commit-bot: I haz the power, 2016-02-23 08:43:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 08:43:31]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[vabr (Chromium), 2016-02-23 08:48:07]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-02-23 08:48:08]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1705813002/#ps240001
(title: "Just rebased")

[commit-bot: I haz the power, 2016-02-23 08:48:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705813002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705813002/240001

[commit-bot: I haz the power, 2016-02-23 10:15:02]

Description was changed from

==========
Remove //chrome and //content deps from ProfileSyncServiceBookmarkTest

BUG=586642
==========

to

==========
Remove //chrome and //content deps from ProfileSyncServiceBookmarkTest

BUG=586642
==========

[commit-bot: I haz the power, 2016-02-23 10:15:03]

Committed patchset #10 (id:240001)

[commit-bot: I haz the power, 2016-02-23 10:16:11]

Description was changed from

==========
Remove //chrome and //content deps from ProfileSyncServiceBookmarkTest

BUG=586642
==========

to

==========
Remove //chrome and //content deps from ProfileSyncServiceBookmarkTest

BUG=586642

Committed: https://crrev.com/0b75a3459bf4e7148230a43b2c42d30a4e0572c2
Cr-Commit-Position: refs/heads/master@{#376960}
==========

[commit-bot: I haz the power, 2016-02-23 10:16:12]

Patchset 10 (id:??) landed as
https://crrev.com/0b75a3459bf4e7148230a43b2c42d30a4e0572c2
Cr-Commit-Position: refs/heads/master@{#376960}