Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1706833002: [runtime] pass in the Isolate into SearchWithCache (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Jarin, Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] pass in the Isolate into SearchWithCache BUG= Committed: https://crrev.com/f3f6b03a75944add08684d7b6f863d36c90a4757 Cr-Commit-Position: refs/heads/master@{#34087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M src/accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/access-info.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/lookup.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-17 15:14:47 UTC) #2
Camillo Bruni
lgtm
4 years, 10 months ago (2016-02-17 15:16:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706833002/1
4 years, 10 months ago (2016-02-17 15:38:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/11124)
4 years, 10 months ago (2016-02-17 15:49:25 UTC) #7
Jarin
compiler change lgtm
4 years, 10 months ago (2016-02-17 16:22:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706833002/1
4 years, 10 months ago (2016-02-17 16:22:42 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 16:23:50 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 16:24:18 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f3f6b03a75944add08684d7b6f863d36c90a4757
Cr-Commit-Position: refs/heads/master@{#34087}

Powered by Google App Engine
This is Rietveld 408576698