Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Side by Side Diff: src/lookup.cc

Issue 1706833002: [runtime] pass in the Isolate into SearchWithCache (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/lookup.h" 5 #include "src/lookup.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/deoptimizer.h" 8 #include "src/deoptimizer.h"
9 #include "src/elements.h" 9 #include "src/elements.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 612 matching lines...) Expand 10 before | Expand all | Expand 10 after
623 JSObject* js_object = JSObject::cast(holder); 623 JSObject* js_object = JSObject::cast(holder);
624 ElementsAccessor* accessor = js_object->GetElementsAccessor(); 624 ElementsAccessor* accessor = js_object->GetElementsAccessor();
625 FixedArrayBase* backing_store = js_object->elements(); 625 FixedArrayBase* backing_store = js_object->elements();
626 number_ = accessor->GetEntryForIndex(js_object, backing_store, index_); 626 number_ = accessor->GetEntryForIndex(js_object, backing_store, index_);
627 if (number_ == kMaxUInt32) { 627 if (number_ == kMaxUInt32) {
628 return holder->IsJSTypedArray() ? INTEGER_INDEXED_EXOTIC : NOT_FOUND; 628 return holder->IsJSTypedArray() ? INTEGER_INDEXED_EXOTIC : NOT_FOUND;
629 } 629 }
630 property_details_ = accessor->GetDetails(js_object, number_); 630 property_details_ = accessor->GetDetails(js_object, number_);
631 } else if (!map->is_dictionary_map()) { 631 } else if (!map->is_dictionary_map()) {
632 DescriptorArray* descriptors = map->instance_descriptors(); 632 DescriptorArray* descriptors = map->instance_descriptors();
633 int number = descriptors->SearchWithCache(*name_, map); 633 int number = descriptors->SearchWithCache(isolate_, *name_, map);
634 if (number == DescriptorArray::kNotFound) return NotFound(holder); 634 if (number == DescriptorArray::kNotFound) return NotFound(holder);
635 number_ = static_cast<uint32_t>(number); 635 number_ = static_cast<uint32_t>(number);
636 property_details_ = descriptors->GetDetails(number_); 636 property_details_ = descriptors->GetDetails(number_);
637 } else if (map->IsJSGlobalObjectMap()) { 637 } else if (map->IsJSGlobalObjectMap()) {
638 GlobalDictionary* dict = JSObject::cast(holder)->global_dictionary(); 638 GlobalDictionary* dict = JSObject::cast(holder)->global_dictionary();
639 int number = dict->FindEntry(name_); 639 int number = dict->FindEntry(name_);
640 if (number == GlobalDictionary::kNotFound) return NOT_FOUND; 640 if (number == GlobalDictionary::kNotFound) return NOT_FOUND;
641 number_ = static_cast<uint32_t>(number); 641 number_ = static_cast<uint32_t>(number);
642 DCHECK(dict->ValueAt(number_)->IsPropertyCell()); 642 DCHECK(dict->ValueAt(number_)->IsPropertyCell());
643 PropertyCell* cell = PropertyCell::cast(dict->ValueAt(number_)); 643 PropertyCell* cell = PropertyCell::cast(dict->ValueAt(number_));
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
681 // Fall through. 681 // Fall through.
682 default: 682 default:
683 return NOT_FOUND; 683 return NOT_FOUND;
684 } 684 }
685 UNREACHABLE(); 685 UNREACHABLE();
686 return state_; 686 return state_;
687 } 687 }
688 688
689 } // namespace internal 689 } // namespace internal
690 } // namespace v8 690 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698