Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Side by Side Diff: src/accessors.cc

Issue 1706833002: [runtime] pass in the Isolate into SearchWithCache (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/accessors.h" 5 #include "src/accessors.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/contexts.h" 8 #include "src/contexts.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/execution.h" 10 #include "src/execution.h"
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 JSTypedArray::kByteLengthOffset, object_offset) && 92 JSTypedArray::kByteLengthOffset, object_offset) &&
93 !CheckForName(name, isolate->factory()->byte_offset_string(), 93 !CheckForName(name, isolate->factory()->byte_offset_string(),
94 JSTypedArray::kByteOffsetOffset, object_offset)) { 94 JSTypedArray::kByteOffsetOffset, object_offset)) {
95 return false; 95 return false;
96 } 96 }
97 97
98 if (map->is_dictionary_map()) return false; 98 if (map->is_dictionary_map()) return false;
99 99
100 // Check if the property is overridden on the instance. 100 // Check if the property is overridden on the instance.
101 DescriptorArray* descriptors = map->instance_descriptors(); 101 DescriptorArray* descriptors = map->instance_descriptors();
102 int descriptor = descriptors->SearchWithCache(*name, *map); 102 int descriptor = descriptors->SearchWithCache(isolate, *name, *map);
103 if (descriptor != DescriptorArray::kNotFound) return false; 103 if (descriptor != DescriptorArray::kNotFound) return false;
104 104
105 Handle<Object> proto = Handle<Object>(map->prototype(), isolate); 105 Handle<Object> proto = Handle<Object>(map->prototype(), isolate);
106 if (!proto->IsJSReceiver()) return false; 106 if (!proto->IsJSReceiver()) return false;
107 107
108 // Check if the property is defined in the prototype chain. 108 // Check if the property is defined in the prototype chain.
109 LookupIterator it(proto, name); 109 LookupIterator it(proto, name);
110 if (!it.IsFound()) return false; 110 if (!it.IsFound()) return false;
111 111
112 Object* original_proto = 112 Object* original_proto =
(...skipping 1091 matching lines...) Expand 10 before | Expand all | Expand 10 after
1204 Isolate* isolate = name->GetIsolate(); 1204 Isolate* isolate = name->GetIsolate();
1205 Handle<AccessorInfo> info = MakeAccessor(isolate, name, &ModuleGetExport, 1205 Handle<AccessorInfo> info = MakeAccessor(isolate, name, &ModuleGetExport,
1206 &ModuleSetExport, attributes); 1206 &ModuleSetExport, attributes);
1207 info->set_data(Smi::FromInt(index)); 1207 info->set_data(Smi::FromInt(index));
1208 return info; 1208 return info;
1209 } 1209 }
1210 1210
1211 1211
1212 } // namespace internal 1212 } // namespace internal
1213 } // namespace v8 1213 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698