Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1706063002: Eliminate ShellClientFactoryConnection & just have the ApplicationManager do it. (Closed)

Created:
4 years, 10 months ago by Ben Goodger (Google)
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@factory
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate ShellClientFactoryConnection & just have the ApplicationManager do it. R=sky@chromium.org BUG= Committed: https://crrev.com/1a4170931b004d98c0e910d74be48bc8e78eed04 Cr-Commit-Position: refs/heads/master@{#376192}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -150 lines) Patch
M content/browser/mojo/mojo_app_connection_impl.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/mojo_shell.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/shell/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/shell/application_instance.h View 3 chunks +0 lines, -11 lines 0 comments Download
M mojo/shell/application_instance.cc View 7 chunks +6 lines, -10 lines 0 comments Download
M mojo/shell/application_manager.h View 1 4 chunks +9 lines, -9 lines 0 comments Download
M mojo/shell/application_manager.cc View 1 2 6 chunks +30 lines, -36 lines 0 comments Download
M mojo/shell/application_manager_unittest.cc View 1 8 chunks +19 lines, -14 lines 0 comments Download
M mojo/shell/connect_util.h View 1 3 chunks +4 lines, -1 line 0 comments Download
M mojo/shell/connect_util.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/identity.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/shell/identity.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/shell/package_test_package.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M mojo/shell/public/cpp/connection.h View 1 chunk +0 lines, -8 lines 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.h View 1 2 3 4 5 1 chunk +1 line, -7 lines 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.cc View 1 2 3 4 5 5 chunks +2 lines, -15 lines 0 comments Download
M mojo/shell/public/cpp/lib/shell_client_factory.cc View 1 2 3 4 5 6 3 chunks +5 lines, -12 lines 0 comments Download
M mojo/shell/public/interfaces/shell.mojom View 1 chunk +1 line, -7 lines 0 comments Download
M mojo/shell/public/interfaces/shell_client_factory.mojom View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 22 (12 generated)
Ben Goodger (Google)
4 years, 10 months ago (2016-02-18 00:54:37 UTC) #1
sky
LGTM
4 years, 10 months ago (2016-02-18 03:30:59 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 1705323003 Patch 1). Please resolve the dependency and ...
4 years, 10 months ago (2016-02-18 03:50:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706063002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706063002/80001
4 years, 10 months ago (2016-02-18 15:00:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/23564) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-18 15:14:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706063002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706063002/100001
4 years, 10 months ago (2016-02-18 15:18:32 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/23749) android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago (2016-02-18 16:12:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706063002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706063002/120001
4 years, 10 months ago (2016-02-18 16:22:06 UTC) #19
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 10 months ago (2016-02-18 17:29:11 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 17:31:34 UTC) #22
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/1a4170931b004d98c0e910d74be48bc8e78eed04
Cr-Commit-Position: refs/heads/master@{#376192}

Powered by Google App Engine
This is Rietveld 408576698