Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1705323003: ContentHandler -> ShellClientFactory (Closed)

Created:
4 years, 10 months ago by Ben Goodger (Google)
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@delete
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ContentHandler -> ShellClientFactory TBR=sky@chromium.org BUG= Committed: https://crrev.com/f451cdbd381c7707f644d41cc1fe30f4cc8a32a2 Cr-Commit-Position: refs/heads/master@{#376117}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -596 lines) Patch
M mojo/mojo_base.gyp View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_shell.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/application_instance.h View 3 chunks +9 lines, -9 lines 0 comments Download
M mojo/shell/application_instance.cc View 5 chunks +4 lines, -5 lines 0 comments Download
M mojo/shell/application_manager.h View 4 chunks +15 lines, -15 lines 0 comments Download
M mojo/shell/application_manager.cc View 5 chunks +27 lines, -27 lines 0 comments Download
D mojo/shell/content_handler_connection.h View 1 chunk +0 lines, -67 lines 0 comments Download
D mojo/shell/content_handler_connection.cc View 1 chunk +0 lines, -78 lines 0 comments Download
M mojo/shell/package_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/package_test_package.cc View 5 chunks +14 lines, -16 lines 0 comments Download
M mojo/shell/public/cpp/BUILD.gn View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M mojo/shell/public/cpp/connection.h View 1 chunk +10 lines, -8 lines 0 comments Download
D mojo/shell/public/cpp/content_handler_factory.h View 1 chunk +0 lines, -82 lines 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.h View 2 chunks +5 lines, -4 lines 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.cc View 4 chunks +7 lines, -7 lines 0 comments Download
D mojo/shell/public/cpp/lib/content_handler_factory.cc View 1 chunk +0 lines, -141 lines 0 comments Download
A + mojo/shell/public/cpp/lib/shell_client_factory.cc View 1 5 chunks +33 lines, -33 lines 0 comments Download
A + mojo/shell/public/cpp/shell_client_factory.h View 1 4 chunks +23 lines, -21 lines 0 comments Download
M mojo/shell/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D mojo/shell/public/interfaces/content_handler.mojom View 1 chunk +0 lines, -20 lines 0 comments Download
A mojo/shell/public/interfaces/shell_client_factory.mojom View 1 chunk +13 lines, -0 lines 0 comments Download
A mojo/shell/shell_client_factory_connection.h View 1 chunk +66 lines, -0 lines 0 comments Download
A + mojo/shell/shell_client_factory_connection.cc View 4 chunks +17 lines, -17 lines 0 comments Download
M mojo/shell/standalone/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/standalone/android/android_handler.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
M mojo/shell/standalone/android/android_handler.cc View 1 2 3 4 3 chunks +20 lines, -23 lines 0 comments Download
M mojo/shell/standalone/switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/standalone/switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Issue 1706063002 Patch 80001
Issue 1706063002 Patch 100001
Issue 1706063002 Patch 120001

Messages

Total messages: 22 (10 generated)
Ben Goodger (Google)
4 years, 10 months ago (2016-02-17 22:37:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705323003/1
4 years, 10 months ago (2016-02-18 03:11:27 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/23550)
4 years, 10 months ago (2016-02-18 03:54:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705323003/20001
4 years, 10 months ago (2016-02-18 04:28:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/68035)
4 years, 10 months ago (2016-02-18 04:34:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705323003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705323003/40001
4 years, 10 months ago (2016-02-18 05:00:26 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/68060)
4 years, 10 months ago (2016-02-18 05:04:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705323003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705323003/60001
4 years, 10 months ago (2016-02-18 05:26:16 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/23610)
4 years, 10 months ago (2016-02-18 06:15:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705323003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705323003/80001
4 years, 10 months ago (2016-02-18 06:35:59 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-18 07:53:47 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 07:54:50 UTC) #22
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/f451cdbd381c7707f644d41cc1fe30f4cc8a32a2
Cr-Commit-Position: refs/heads/master@{#376117}

Powered by Google App Engine
This is Rietveld 408576698