Move various Shell tests into a subdir.

Move various Shell tests into a subdir.

TBR=sky@chromium.org
BUG=

Committed: https://crrev.com/a7a6196257751af4e1bf769d60cb566c437f28e8
Cr-Commit-Position: refs/heads/master@{#376255}

[Ben Goodger (Google), 2016-02-18 17:54:50]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2016-02-18 17:56:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706833003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706833003/40001

[commit-bot: I haz the power, 2016-02-18 19:14:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 19:14:21]

Failed to apply patch for BUILD.gn:
While running git apply --index -3 -p1;
  error: patch failed: BUILD.gn:603
  Falling back to three-way merge...
  Applied patch to 'BUILD.gn' with conflicts.
  U BUILD.gn

Patch:       BUILD.gn
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index
57087a378a3d325f44c44f9dac2d8e50844dbee8..ae256bb5fb3ca6bc91c852a8e09232181ec3bc69
100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -603,7 +603,7 @@ group("mojo_apptests") {
       "//mash/wm:tests",
       "//media/mojo/services:tests",
       "//mojo/services/network:apptests",
-      "//mojo/shell:apptests",
+      "//mojo/shell/tests:apptests",
       "//sql/mojo:apptests",
       "//ui/views/mus:tests",
     ]

[commit-bot: I haz the power, 2016-02-18 19:17:34]

The CQ bit was unchecked by commit-bot@chromium.org

[Ben Goodger (Google), 2016-02-18 19:30:33]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2016-02-18 19:34:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1706833003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1706833003/60001

[commit-bot: I haz the power, 2016-02-18 20:56:31]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-18 20:57:24]

Description was changed from

==========
Move various Shell tests into a subdir.

TBR=sky@chromium.org
BUG=
==========

to

==========
Move various Shell tests into a subdir.

TBR=sky@chromium.org
BUG=

Committed: https://crrev.com/a7a6196257751af4e1bf769d60cb566c437f28e8
Cr-Commit-Position: refs/heads/master@{#376255}
==========

[commit-bot: I haz the power, 2016-02-18 20:57:25]

Patchset 4 (id:??) landed as
https://crrev.com/a7a6196257751af4e1bf769d60cb566c437f28e8
Cr-Commit-Position: refs/heads/master@{#376255}

[Theresa, 2016-02-18 22:31:02]

twellington@chromium.org changed reviewers:
+ twellington@chromium.org

[Theresa, 2016-02-18 22:31:03]

It looks like the change is causing compilation failures on the Android x86 bot
(probably others will start failing
soon):https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20x86%20Builder%20%28dbg%29/builds/2917

This is the error: ../../mojo/shell/tests/package_test_package.cc:16:43: fatal
error: mojo/shell/package_test.mojom.h: No such file or directory #include
"mojo/shell/package_test.mojom.h"
18 mins

This is a rather big patch to revert.. ben@, can you please take a look and let
me know if you can get a fix in quickly?

[Ben Goodger (Google), 2016-02-18 22:50:35]

On 2016/02/18 22:31:03, Theresa Wellington wrote:
> It looks like the change is causing compilation failures on the Android x86
bot
> (probably others will start failing
>
soon):https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20x86%20Builder%20%28dbg%29/builds/2917
> 
> This is the error: ../../mojo/shell/tests/package_test_package.cc:16:43: fatal
> error: mojo/shell/package_test.mojom.h: No such file or directory #include
> "mojo/shell/package_test.mojom.h"
> 18 mins
> 
> This is a rather big patch to revert.. ben@, can you please take a look and
let
> me know if you can get a fix in quickly?

Fixes have been landed or are in CQ @

https://codereview.chromium.org/1711133002/
https://codereview.chromium.org/1714673002/