Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1705583003: clean up more dead code (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

clean up more dead code - SkSHA1 is unused - SkRunnable is obsolete now that we have std::function BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705583003 Committed: https://skia.googlesource.com/skia/+/048494c1e236c4db9d18952de83d2602c1abc7c3

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -446 lines) Patch
M bench/ChecksumBench.cpp View 1 4 chunks +0 lines, -12 lines 0 comments Download
M gyp/utils.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkTaskGroup.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/core/SkTaskGroup.cpp View 4 chunks +0 lines, -11 lines 0 comments Download
D src/utils/SkRunnable.h View 1 chunk +0 lines, -16 lines 0 comments Download
D src/utils/SkSHA1.h View 1 chunk +0 lines, -55 lines 0 comments Download
D src/utils/SkSHA1.cpp View 1 chunk +0 lines, -268 lines 0 comments Download
M tests/OnceTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsSkpClipTest.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M tests/PathOpsThreadedCommon.h View 3 chunks +2 lines, -3 lines 0 comments Download
M tests/PathOpsThreadedCommon.cpp View 1 chunk +1 line, -1 line 0 comments Download
D tests/SHA1Test.cpp View 1 chunk +0 lines, -53 lines 0 comments Download
M tests/SkpSkGrTest.cpp View 4 chunks +3 lines, -6 lines 0 comments Download
M tests/skia_test.cpp View 5 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705583003/1
4 years, 10 months ago (2016-02-17 02:36:39 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/6243) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on ...
4 years, 10 months ago (2016-02-17 02:37:40 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705583003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705583003/20001
4 years, 10 months ago (2016-02-17 02:40:48 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 03:02:48 UTC) #9
mtklein
lgtm
4 years, 10 months ago (2016-02-17 03:05:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705583003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705583003/20001
4 years, 10 months ago (2016-02-17 03:05:36 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 03:06:18 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/048494c1e236c4db9d18952de83d2602c1abc7c3

Powered by Google App Engine
This is Rietveld 408576698