Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: tests/SkpSkGrTest.cpp

Issue 1705583003: clean up more dead code (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/SHA1Test.cpp ('k') | tests/skia_test.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/SkpSkGrTest.cpp
diff --git a/tests/SkpSkGrTest.cpp b/tests/SkpSkGrTest.cpp
index 241395a7533c09e80d76541295e6b4d11c5df6b6..8cc7ec4a2d98817a7b569245dd91e890435862dd 100644
--- a/tests/SkpSkGrTest.cpp
+++ b/tests/SkpSkGrTest.cpp
@@ -21,7 +21,6 @@
#include "SkOSFile.h"
#include "SkPicture.h"
#include "SkRTConf.h"
-#include "SkRunnable.h"
#include "SkStream.h"
#include "SkString.h"
#include "SkTArray.h"
@@ -142,7 +141,7 @@ struct SkpSkGrThreadedTestRunner {
skiatest::Reporter* fReporter;
};
-class SkpSkGrThreadedRunnable : public SkRunnable {
+class SkpSkGrThreadedRunnable {
public:
SkpSkGrThreadedRunnable(void (*testFun)(SkpSkGrThreadState*), int dirNo, const char* str,
SkpSkGrThreadedTestRunner* runner) {
@@ -153,7 +152,7 @@ public:
fTestFun = testFun;
}
- void run() override {
+ void operator()() {
SkGraphics::SetTLSFontCacheLimit(1 * 1024 * 1024);
(*fTestFun)(&fState);
}
@@ -169,10 +168,8 @@ SkpSkGrThreadedTestRunner::~SkpSkGrThreadedTestRunner() {
}
void SkpSkGrThreadedTestRunner::render() {
- // TODO: we don't really need to be using SkRunnables here anymore.
- // We can just write the code we'd run right in the for loop.
SkTaskGroup().batch(fRunnables.count(), [&](int i) {
- fRunnables[i]->run();
+ fRunnables[i]();
});
}
« no previous file with comments | « tests/SHA1Test.cpp ('k') | tests/skia_test.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698