ContentHandler -> ShellClientFactory

mojo/shell/standalone/android/android_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/shell/standalone/android/android_handler.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/android/context_utils.h"
@@ skipping 69 matching lines @@
 // .mojo file.
 bool IsCachedApp(JNIEnv* env,
                  const GURL& url,
                  base::FilePath* app_dir,
                  base::FilePath* path_to_mojo) {
   ScopedJavaLocalRef<jstring> j_cached_apps_dir =
       Java_AndroidHandler_getCachedAppsDir(env, GetApplicationContext());
   const base::FilePath cached_apps_fp(
       ConvertJavaStringToUTF8(env, j_cached_apps_dir.obj()));
   const std::string cached_apps(util::FilePathToFileURL(cached_apps_fp).spec());
-  const std::string response_url(GURL(url).spec());
+  const std::string response_url(url.spec());
   if (response_url.size() <= cached_apps.size() ||
       cached_apps.compare(0u, cached_apps.size(), response_url, 0u,
                           cached_apps.size()) != 0) {
     return false;
   }
 
   const std::string mojo_suffix(".mojo");
   // app_rel_path is either something like html_viewer/html_viewer.mojo, or
   // html_viewer.mojo, depending upon whether the app has a package.
   const std::string app_rel_path(response_url.substr(cached_apps.size() + 1));
@@ skipping 20 matching lines @@
   }
 
   *app_dir = cached_apps_fp.Append(
       app_rel_path.substr(0, app_rel_path.size() - mojo_suffix.size()));
   *path_to_mojo = cached_apps_fp.Append(app_rel_path);
   return true;
 }
 
 }  // namespace
 
-AndroidHandler::AndroidHandler() : content_handler_factory_(this) {}
+AndroidHandler::AndroidHandler() : shell_client_factory_(this) {}
 
 AndroidHandler::~AndroidHandler() {}
 
-void AndroidHandler::RunApplication(
-    InterfaceRequest<mojom::ShellClient> request,
-    URLResponsePtr response) {
+void AndroidHandler::CreateShellClient(mojom::ShellClientRequest request,
+                                       const GURL& url) {
   JNIEnv* env = AttachCurrentThread();
   RunAndroidApplicationFn run_android_application_fn = &RunAndroidApplication;
-  if (!response->url.is_null()) {
-    base::FilePath internal_app_path;
-    base::FilePath path_to_mojo;
-    if (IsCachedApp(env, GURL(response->url.get()), &internal_app_path,
-                    &path_to_mojo)) {
-      ScopedJavaLocalRef<jstring> j_internal_app_path(
-          ConvertUTF8ToJavaString(env, internal_app_path.value()));
-      ScopedJavaLocalRef<jstring> j_path_to_mojo(
-          ConvertUTF8ToJavaString(env, path_to_mojo.value()));
-      Java_AndroidHandler_bootstrapCachedApp(
-          env, GetApplicationContext(), j_path_to_mojo.obj(),
-          j_internal_app_path.obj(),
-          request.PassMessagePipe().release().value(),
-          reinterpret_cast<jlong>(run_android_application_fn));
-      return;
-    }
+  base::FilePath internal_app_path;
+  base::FilePath path_to_mojo;
+  if (IsCachedApp(env, url, &internal_app_path, &path_to_mojo)) {
+    ScopedJavaLocalRef<jstring> j_internal_app_path(
+        ConvertUTF8ToJavaString(env, internal_app_path.value()));
+    ScopedJavaLocalRef<jstring> j_path_to_mojo(
+        ConvertUTF8ToJavaString(env, path_to_mojo.value()));
+    Java_AndroidHandler_bootstrapCachedApp(
+        env, GetApplicationContext(), j_path_to_mojo.obj(),
+        j_internal_app_path.obj(),
+        request.PassMessagePipe().release().value(),
+        reinterpret_cast<jlong>(run_android_application_fn));
+    return;
   }
   ScopedJavaLocalRef<jstring> j_archive_path =
       Java_AndroidHandler_getNewTempArchivePath(env, GetApplicationContext());
   base::FilePath archive_path(
       ConvertJavaStringToUTF8(env, j_archive_path.obj()));
 
-  common::BlockingCopyToFile(std::move(response->body), archive_path);
+  // TODO(beng): fix or remove.
+  //common::BlockingCopyToFile(std::move(response->body), archive_path);
   Java_AndroidHandler_bootstrap(
       env, GetApplicationContext(), j_archive_path.obj(),
       request.PassMessagePipe().release().value(),
       reinterpret_cast<jlong>(run_android_application_fn));
 }
 
 void AndroidHandler::Initialize(Shell* shell,
                                 const std::string& url,
                                 uint32_t id) {}
 
 bool AndroidHandler::AcceptConnection(Connection* connection) {
-  connection->AddInterface(&content_handler_factory_);
+  connection->AddInterface(&shell_client_factory_);
   return true;
 }
 
 bool RegisterAndroidHandlerJni(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace shell
 }  // namespace mojo