Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2016)

Issue 170503002: Implement addPath() method for Path object (Closed)

Created:
6 years, 10 months ago by pals
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, krit, arv+blink, pdr., dsinclair, rwlbuis, jbroman, danakj, dglazkov+blink, adamk+blink_chromium.org, Stephen Chennney, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 16

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -5 lines) Patch
A + LayoutTests/fast/canvas/canvas-path-addpath.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/canvas/canvas-path-addpath-expected.txt View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/script-tests/canvas-path-addpath.js View 1 2 3 1 chunk +91 lines, -0 lines 0 comments Download
M Source/core/html/canvas/CanvasPathMethods.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/DOMPath.h View 1 2 3 3 chunks +14 lines, -4 lines 0 comments Download
M Source/core/html/canvas/Path.idl View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/graphics/Path.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/graphics/Path.cpp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (0 generated)
pals
Please review.
6 years, 10 months ago (2014-02-18 14:40:09 UTC) #1
rwlbuis
https://codereview.chromium.org/170503002/diff/1/Source/core/html/canvas/DOMPath.h File Source/core/html/canvas/DOMPath.h (right): https://codereview.chromium.org/170503002/diff/1/Source/core/html/canvas/DOMPath.h#newcode55 Source/core/html/canvas/DOMPath.h:55: m_path = path->path(); You can put this in the ...
6 years, 10 months ago (2014-02-18 15:59:59 UTC) #2
jbroman
https://codereview.chromium.org/170503002/diff/1/Source/platform/graphics/Path.cpp File Source/platform/graphics/Path.cpp (right): https://codereview.chromium.org/170503002/diff/1/Source/platform/graphics/Path.cpp#newcode442 Source/platform/graphics/Path.cpp:442: } drive-by nit: newline below this method, please.
6 years, 10 months ago (2014-02-18 16:06:46 UTC) #3
Justin Novosad
Was there an intent to implement thread for this on blink-dev? https://codereview.chromium.org/170503002/diff/1/LayoutTests/fast/canvas/script-tests/canvas-path-addpath.js File LayoutTests/fast/canvas/script-tests/canvas-path-addpath.js (right): ...
6 years, 10 months ago (2014-02-18 16:09:29 UTC) #4
pals
On 2014/02/18 16:09:29, junov wrote: > Was there an intent to implement thread for this ...
6 years, 10 months ago (2014-02-18 16:35:45 UTC) #5
Justin Novosad
On 2014/02/18 16:35:45, sanjoy.pal wrote: > On 2014/02/18 16:09:29, junov wrote: > > Was there ...
6 years, 10 months ago (2014-02-18 16:42:46 UTC) #6
Rik
On 2014/02/18 14:40:09, sanjoy.pal wrote: > Please review. Some people have expressed unease with have ...
6 years, 10 months ago (2014-02-18 17:00:26 UTC) #7
pals
Fixed the review comments. I shall send an Intent to implement on blink-dev as well. ...
6 years, 10 months ago (2014-02-19 11:47:21 UTC) #8
Justin Novosad
lgtm with minor corrections. Please give people on blink-dev time to respond. Wait one week ...
6 years, 10 months ago (2014-02-19 16:38:28 UTC) #9
pals
Its more than a week. The intent-to-implement haven't received any LGTM's from API owners. Should ...
6 years, 9 months ago (2014-03-03 06:27:38 UTC) #10
Justin Novosad
On 2014/03/03 06:27:38, sanjoy.pal wrote: > Its more than a week. The intent-to-implement haven't received ...
6 years, 9 months ago (2014-03-03 15:49:06 UTC) #11
pals
The CQ bit was checked by sanjoy.pal@samsung.com
6 years, 9 months ago (2014-03-04 08:14:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/170503002/270001
6 years, 9 months ago (2014-03-04 08:15:41 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 09:01:24 UTC) #14
commit-bot: I haz the power
Retried try job too often on mac_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout&number=21734
6 years, 9 months ago (2014-03-04 09:01:25 UTC) #15
pals
The CQ bit was checked by sanjoy.pal@samsung.com
6 years, 9 months ago (2014-03-04 10:38:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/170503002/270001
6 years, 9 months ago (2014-03-04 10:38:56 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 11:06:43 UTC) #18
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) blink_heap_unittests, blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, ...
6 years, 9 months ago (2014-03-04 11:06:43 UTC) #19
pals
On 2014/03/04 11:06:43, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 9 months ago (2014-03-04 14:42:57 UTC) #20
Justin Novosad
lgtm
6 years, 9 months ago (2014-03-04 16:37:43 UTC) #21
pals
The CQ bit was checked by sanjoy.pal@samsung.com
6 years, 9 months ago (2014-03-05 05:48:56 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/170503002/300001
6 years, 9 months ago (2014-03-05 05:49:40 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/170503002/300001
6 years, 9 months ago (2014-03-05 20:55:51 UTC) #24
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 03:51:32 UTC) #25
Message was sent while issue was closed.
Change committed as 168561

Powered by Google App Engine
This is Rietveld 408576698