Implement addPath() method for Path object

Source/core/html/canvas/DOMPath.h

 /*
  * Copyright (C) 2012, 2013 Adobe Systems Incorporated. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 12 matching lines @@
  * TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
  * THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  */
 
 #ifndef DOMPath_h
 #define DOMPath_h
 
 #include "bindings/v8/ScriptWrappable.h"
 #include "core/html/canvas/CanvasPathMethods.h"
+#include "core/svg/SVGMatrix.h"
 #include "core/svg/SVGPathUtilities.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefCounted.h"
 
 namespace WebCore {
 
 class DOMPath FINAL : public RefCounted<DOMPath>, public CanvasPathMethods, public ScriptWrappable {
     WTF_MAKE_NONCOPYABLE(DOMPath); WTF_MAKE_FAST_ALLOCATED;
 public:
     static PassRefPtr<DOMPath> create() { return adoptRef(new DOMPath); }
     static PassRefPtr<DOMPath> create(const String& pathData) { return adoptRef(new DOMPath(pathData)); }
     static PassRefPtr<DOMPath> create(DOMPath* path) { return adoptRef(new DOMPath(path)); }
 
     static PassRefPtr<DOMPath> create(const Path& path) { return adoptRef(new DOMPath(path)); }
 
     const Path& path() const { return m_path; }
 
+    DOMPath(DOMPath* path)

[Justin Novosad, 2014/02/18 16:09:29]

This is weird. This is kind of like a public copy constructor, but not quite,
yet this class has WTF_MAKE_NONCOPYABLE(DOMPath).  It looks too much like
cheating.  Perhaps we should have a clone() method instead?

[pals, 2014/02/19 11:47:22]

Done. Reverted this change.

+        : CanvasPathMethods()
+    {
+        ScriptWrappable::init(this);
+        m_path = path->path();

[rwlbuis, 2014/02/18 15:59:59]

You can put this in the initialization list, it is a bit more efficient.

[pals, 2014/02/19 11:47:22]

Done.

+    }
+
     virtual ~DOMPath() { }
+
+    void addPath(const DOMPath& path, const SVGMatrix& transform)
+    {
+        Path src = path.path();
+        m_path.addPath(src, transform);
+    }
 private:
     DOMPath() : CanvasPathMethods()
     {
         ScriptWrappable::init(this);
     }
 
     DOMPath(const Path& path)
         : CanvasPathMethods()
     {
         ScriptWrappable::init(this);
         m_path = path;
     }
 
-    DOMPath(DOMPath* path)
-        : CanvasPathMethods()
-    {
-        ScriptWrappable::init(this);
-        m_path = path->path();
-    }
-
     DOMPath(const String& pathData)
         : CanvasPathMethods()
     {
         ScriptWrappable::init(this);
         buildPathFromString(pathData, m_path);
     }
 };
 
 }
 #endif