Simplified linear pipeline.

Simplified linear pipeline.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1704583003

Committed: https://skia.googlesource.com/skia/+/feec878e850850cb0a092a765e3af0f5a3fa2a42

[herb_g, 2016-02-16 20:14:08]

Description was changed from

==========
Simplified linear pipeline.

BUG=skia:
==========

to

==========
Simplified linear pipeline.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-02-16 20:16:23]

Description was changed from

==========
Simplified linear pipeline.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Simplified linear pipeline.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2016-02-16 20:16:23]

herb@google.com changed reviewers:
+ mtklein@google.com, reed@google.com

[herb_g, 2016-02-16 20:18:04]

At Mike's request, I have produced a CL that has the basic point pipeline. It's
simple, but does not handle bilerp or have good performance. These features will
be added in subsequent CLs.

[mtklein, 2016-02-16 21:13:11]

lgtm

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
File src/core/SkLinearBitmapPipeline.cpp (right):

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:32: void SpanFallback(SkPoint start,
SkScalar length, int count, Next* next) {
suspiciously similar to shadeSpan

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:58: fStrategy.processPoints(n, &xs, &ys);
it looks like no strategy needs n

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:63: fStrategy.processPoints(4, &xs, &ys);
ditto

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:72: class AbortPointProcessor final : public
PointProcessorInterface {
SkippedStage?

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:81: class IdentityMatrixStrategy {
dead code?

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:275: inline Sk4f bilerp4(SkPoint pt, Sk4f
pixel00, Sk4f pixel01,
die

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:301: Sk4f getPixel(const uint32_t* src, int
index) {
private?

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:356: fStrategy.getFewPixels(n, xs, ys, &px0,
&px1, &px2, &px3);
should not need px3?

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:357: if (0 == n) return;
assert n < 4 && n > 0?

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:358: fNext->placePixel(px0);
if (n > 0) { fNext->placePixel(px0); }
if (n > 1) { fNext->placePixel(px1); }
if (n > 2) { fNext->placePixel(px2); }

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:456: auto placementStage =
choose_pixel_placer(srcImageInfo.alphaType(), &fPixelStage);
Let's explain how the stages may be missing, etc.

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:467: Sk4f Xs = Sk4f(x) + Sk4f{0.0f, 1.0f,
2.0f, 3.0f};
+ 0.5?

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
File src/core/SkLinearBitmapPipeline.h (right):

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.h:37: template<typename Base, size_t kSize = 80>
Seems clearer without a default.

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.h:64: using MatrixStage =
PolymorphicUnion<PointProcessorInterface, 112>;
Move inside SKLinearBitmapPipeline?

[herb_g, 2016-02-16 21:38:04]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 21:38:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1704583003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1704583003/1

[commit-bot: I haz the power, 2016-02-16 21:39:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 21:39:18]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[herb_g, 2016-02-16 22:04:25]

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
File src/core/SkLinearBitmapPipeline.cpp (right):

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:32: void SpanFallback(SkPoint start,
SkScalar length, int count, Next* next) {
On 2016/02/16 21:13:10, mtklein wrote:
> suspiciously similar to shadeSpan

removed

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:58: fStrategy.processPoints(n, &xs, &ys);
On 2016/02/16 21:13:10, mtklein wrote:
> it looks like no strategy needs n

Done.

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:63: fStrategy.processPoints(4, &xs, &ys);
On 2016/02/16 21:13:10, mtklein wrote:
> ditto

Done.

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:72: class AbortPointProcessor final : public
PointProcessorInterface {
On 2016/02/16 21:13:10, mtklein wrote:
> SkippedStage?

Done.

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:81: class IdentityMatrixStrategy {
On 2016/02/16 21:13:10, mtklein wrote:
> dead code?

Done.

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:275: inline Sk4f bilerp4(SkPoint pt, Sk4f
pixel00, Sk4f pixel01,
On 2016/02/16 21:13:10, mtklein wrote:
> die

Done.

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:301: Sk4f getPixel(const uint32_t* src, int
index) {
On 2016/02/16 21:13:10, mtklein wrote:
> private?

Done.

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:356: fStrategy.getFewPixels(n, xs, ys, &px0,
&px1, &px2, &px3);
On 2016/02/16 21:13:10, mtklein wrote:
> should not need px3?

Done.

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:357: if (0 == n) return;
On 2016/02/16 21:13:10, mtklein wrote:
> assert n < 4 && n > 0?

Done.

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:358: fNext->placePixel(px0);
On 2016/02/16 21:13:10, mtklein wrote:
> if (n > 0) { fNext->placePixel(px0); }
> if (n > 1) { fNext->placePixel(px1); }
> if (n > 2) { fNext->placePixel(px2); }

Done.

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:456: auto placementStage =
choose_pixel_placer(srcImageInfo.alphaType(), &fPixelStage);
On 2016/02/16 21:13:10, mtklein wrote:
> Let's explain how the stages may be missing, etc.

Done.

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.cpp:467: Sk4f Xs = Sk4f(x) + Sk4f{0.0f, 1.0f,
2.0f, 3.0f};
On 2016/02/16 21:13:10, mtklein wrote:
> + 0.5?

Done.

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
File src/core/SkLinearBitmapPipeline.h (right):

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.h:37: template<typename Base, size_t kSize = 80>
On 2016/02/16 21:13:10, mtklein wrote:
> Seems clearer without a default.

Done.

https://codereview.chromium.org/1704583003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline.h:64: using MatrixStage =
PolymorphicUnion<PointProcessorInterface, 112>;
On 2016/02/16 21:13:10, mtklein wrote:
> Move inside SKLinearBitmapPipeline?

Done.

[herb_g, 2016-02-16 22:29:59]

Address comments, and change to const ref for args.

[herb_g, 2016-02-16 22:30:21]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 22:30:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1704583003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1704583003/20001

[commit-bot: I haz the power, 2016-02-16 22:33:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 22:33:05]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[herb_g, 2016-02-16 22:36:10]

Use union for space.

[herb_g, 2016-02-16 22:40:22]

Remove alignment check.

[herb_g, 2016-02-16 22:40:55]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 22:40:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1704583003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1704583003/60001

[commit-bot: I haz the power, 2016-02-16 22:42:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 22:42:06]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[herb_g, 2016-02-16 22:53:54]

Fix test compiler errors.

[herb_g, 2016-02-16 22:58:05]

Fix union problems.

[herb_g, 2016-02-16 22:58:58]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 22:59:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1704583003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1704583003/100001

[commit-bot: I haz the power, 2016-02-16 23:00:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 23:00:16]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[herb_g, 2016-02-16 23:26:27]

Fix alignment in a different way.

[herb_g, 2016-02-16 23:26:57]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 23:27:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1704583003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1704583003/120001

[commit-bot: I haz the power, 2016-02-16 23:28:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 23:28:26]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[herb_g, 2016-02-16 23:30:32]

Fix unused result.

[herb_g, 2016-02-16 23:36:02]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 23:36:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1704583003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1704583003/140001

[commit-bot: I haz the power, 2016-02-16 23:37:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 23:37:28]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[herb_g, 2016-02-16 23:40:47]

More ignore results.

[herb_g, 2016-02-16 23:41:37]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 23:41:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1704583003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1704583003/160001

[commit-bot: I haz the power, 2016-02-16 23:44:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 23:44:32]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[herb_g, 2016-02-16 23:52:32]

Handle native rgb properly.

[herb_g, 2016-02-16 23:53:48]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 23:53:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1704583003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1704583003/180001

[commit-bot: I haz the power, 2016-02-16 23:56:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 23:56:28]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[herb_g, 2016-02-17 00:00:59]

An additional stack allocation.

[herb_g, 2016-02-17 00:01:32]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 00:01:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1704583003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1704583003/200001

[commit-bot: I haz the power, 2016-02-17 00:04:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 00:04:19]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
  Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)

[herb_g, 2016-02-17 01:15:46]

Fix more errors.

[herb_g, 2016-02-17 01:16:19]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 01:16:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1704583003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1704583003/220001

[commit-bot: I haz the power, 2016-02-17 01:18:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 01:18:53]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[herb_g, 2016-02-17 01:33:09]

Fix lose of precision.

[herb_g, 2016-02-17 01:33:39]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 01:33:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1704583003/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1704583003/240001

[commit-bot: I haz the power, 2016-02-17 01:36:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 01:36:43]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[herb_g, 2016-02-17 01:41:02]

More 0 len array.

[herb_g, 2016-02-17 01:41:29]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 01:41:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1704583003/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1704583003/260001

[commit-bot: I haz the power, 2016-02-17 01:44:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 01:44:20]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[herb_g, 2016-02-17 17:11:23]

Fix unaligned size problem.

[herb_g, 2016-02-17 17:11:39]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 17:11:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1704583003/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1704583003/280001

[commit-bot: I haz the power, 2016-02-17 17:50:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 17:50:01]

Dry run: This issue passed the CQ dry run.

[herb_g, 2016-02-17 17:58:19]

The CQ bit was checked by herb@google.com

[herb_g, 2016-02-17 17:58:19]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1704583003/#ps280001
(title: "Fix unaligned size problem.")

[commit-bot: I haz the power, 2016-02-17 17:58:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1704583003/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1704583003/280001

[commit-bot: I haz the power, 2016-02-17 18:00:11]

Description was changed from

==========
Simplified linear pipeline.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Simplified linear pipeline.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/feec878e850850cb0a092a765e3af0f5a3fa2a42
==========

[commit-bot: I haz the power, 2016-02-17 18:00:12]

Committed patchset #15 (id:280001) as
https://skia.googlesource.com/skia/+/feec878e850850cb0a092a765e3af0f5a3fa2a42

[tomhudson, 2016-02-17 18:46:37]

Appears to be breaking ASAN with use-after-free:
https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-G...

[bungeman-skia, 2016-02-17 19:36:33]

bungeman@google.com changed reviewers:
+ bungeman@google.com

[bungeman-skia, 2016-02-17 19:36:34]

https://codereview.chromium.org/1704583003/diff/280001/bench/SkLinearBitmapPi...
File bench/SkLinearBitmapPipelineBench.cpp (right):

https://codereview.chromium.org/1704583003/diff/280001/bench/SkLinearBitmapPi...
bench/SkLinearBitmapPipelineBench.cpp:74: return name.c_str();
Gone! This is being reported by asan, because the local SkString is being
destroyed and freeing the data.

[bungeman-skia, 2016-02-17 20:10:18]

https://codereview.chromium.org/1704583003/diff/280001/bench/SkLinearBitmapPi...
File bench/SkLinearBitmapPipelineBench.cpp (right):

https://codereview.chromium.org/1704583003/diff/280001/bench/SkLinearBitmapPi...
bench/SkLinearBitmapPipelineBench.cpp:74: return name.c_str();
On 2016/02/17 19:36:34, bungeman1 wrote:
> Gone! This is being reported by asan, because the local SkString is being
> destroyed and freeing the data.

This is now fixed with https://codereview.chromium.org/1701413003/ .

[bungeman-skia, 2016-02-17 21:38:41]

https://codereview.chromium.org/1704583003/diff/280001/bench/SkLinearBitmapPi...
File bench/SkLinearBitmapPipelineBench.cpp (right):

https://codereview.chromium.org/1704583003/diff/280001/bench/SkLinearBitmapPi...
bench/SkLinearBitmapPipelineBench.cpp:201: delete buffer4b;
This is also causing asan issues...

delete [] buffer4b;

[bungeman-skia, 2016-02-17 21:53:21]

On 2016/02/17 21:38:41, bungeman1 wrote:
>
https://codereview.chromium.org/1704583003/diff/280001/bench/SkLinearBitmapPi...
> File bench/SkLinearBitmapPipelineBench.cpp (right):
> 
>
https://codereview.chromium.org/1704583003/diff/280001/bench/SkLinearBitmapPi...
> bench/SkLinearBitmapPipelineBench.cpp:201: delete buffer4b;
> This is also causing asan issues...
> 
> delete [] buffer4b;

This issue fixed with https://codereview.chromium.org/1703203003/ .